Re: [patch] net/tulip: LAN driver for ULI M5261/M5263

Re: [patch] net/tulip: LAN driver for ULI M5261/M5263

[Jeff Garzik]

Peer.Chen@uli.com.tw wrote:
> We want to extract our LAN card driver from tulip core driver and make a
> new file uli526x.c at tulip folder,
> because we have added some ethtool interface support and non-eprom support
> in our driver and may be other change
> in the futher. If our controllers support are still contained in the tulip
> core driver, I think it'll increase the
> complexity of maintenance,


After some thought, I agree with this assessment.

It has been my goal for a long time to separate out the various chips 
from the tulip driver, for easier maintenance.  One of the reasons I 
have not applied a "fix tulip for ULi" patch is that it changes PHY 
details that I am not sure are OK for the myriad tulip clones.  A 
separate driver eliminates this objection.

I have applied your patch to the new 'uli-tulip' branch of git 
repository 
rsync://rsync.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git

Please now do the following tasks:

1) Submit an incremental patch addressing Alexey Dobriyan's minor complaints

2) Submit a patch removing all ULi support from the 'tulip' driver


I will then conduct a final review, and probably request another patch, 
with more updates.

After that, your driver will be sent upstream, to be included in the 
official 2.6.x kernel.

Thanks and regards,

	Jeff

Re: [patch] net/tulip: LAN driver for ULI M5261/M5263

[Jeff Garzik]

Peer.Chen@uli.com.tw wrote:
> Jeff:
> The attached file is the incremental patch to the original uli526x.c I send
> you first time,
> I modify the source according to your advice, thanks.
> 
> Signed-off-by: Peer Chen <Peer.Chen@uli.com.tw>
> (See attached file: patch_uli526x_inc)

Patch applied, thanks much.

I notice you removed the following code, rather than fixing it.  It is
OK to remove this code??


-       //add by clearzhang 2004/7/8
-       pci_read_config_dword(pdev,0x0,&configval);
-       m526x_id = configval;
-       if(configval == 0x526310b9)
-       {
-               //printk("is m5263\n");
-               pci_read_config_dword(pdev,0x0c,&configval);
-               configval = ((configval & 0xffff00ff) | 0x8000);
-               pci_write_config_dword(pdev,0x0c,configval);
-       }

Thanks,

	Jeff