From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [patch] net/tulip: LAN driver for ULI M5261/M5263 Date: Sat, 20 Aug 2005 01:12:25 -0400 Message-ID: <4306BBB9.4060201@pobox.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Cc: Alexey Dobriyan , Alan Cox , Clear.Zhang@uli.com.tw, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Emily.Jiang@uli.com.tw Return-path: To: Peer.Chen@uli.com.tw In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Peer.Chen@uli.com.tw wrote: > Jeff: > The attached file is the incremental patch to the original uli526x.c I send > you first time, > I modify the source according to your advice, thanks. > > Signed-off-by: Peer Chen > (See attached file: patch_uli526x_inc) Patch applied, thanks much. I notice you removed the following code, rather than fixing it. It is OK to remove this code?? - //add by clearzhang 2004/7/8 - pci_read_config_dword(pdev,0x0,&configval); - m526x_id = configval; - if(configval == 0x526310b9) - { - //printk("is m5263\n"); - pci_read_config_dword(pdev,0x0c,&configval); - configval = ((configval & 0xffff00ff) | 0x8000); - pci_write_config_dword(pdev,0x0c,configval); - } Thanks, Jeff