From: Ben Greear <greearb@candelatech.com>
To: "'netdev@oss.sgi.com'" <netdev@oss.sgi.com>
Subject: Netdevice reference counting issues in net/core/dv.c
Date: Sat, 27 Aug 2005 23:42:54 -0700 [thread overview]
Message-ID: <43115CEE.9030306@candelatech.com> (raw)
dv.c has several issues.
First, it uses the check_args method to find the
device. It acquires a hold on the device and then
drops it in the same method. Upon return from this
check_args method, code then continues to use the reference
to the device. This could lead to access-after-free errors.
Also, check_args has an arbitrary device-index check to make
sure it is less that 1000. This is bogus since we can have many
more devices than that...
If there is a maintainer that wants to fix this, please be my
guest. Otherwise, I'll make a stab at fixing it as part of
my ref-count debugging work.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
reply other threads:[~2005-08-28 6:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43115CEE.9030306@candelatech.com \
--to=greearb@candelatech.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).