* Netdevice reference counting issues in net/core/dv.c
@ 2005-08-28 6:42 Ben Greear
0 siblings, 0 replies; only message in thread
From: Ben Greear @ 2005-08-28 6:42 UTC (permalink / raw)
To: 'netdev@oss.sgi.com'
dv.c has several issues.
First, it uses the check_args method to find the
device. It acquires a hold on the device and then
drops it in the same method. Upon return from this
check_args method, code then continues to use the reference
to the device. This could lead to access-after-free errors.
Also, check_args has an arbitrary device-index check to make
sure it is less that 1000. This is bogus since we can have many
more devices than that...
If there is a maintainer that wants to fix this, please be my
guest. Otherwise, I'll make a stab at fixing it as part of
my ref-count debugging work.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-08-28 6:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-28 6:42 Netdevice reference counting issues in net/core/dv.c Ben Greear
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).