From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Andrew Morton <akpm@osdl.org>,
jmcgowan@inch.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: Kernel 2.6.13 breaks libpcap (and tcpdump).
Date: Sun, 04 Sep 2005 19:31:26 +0200 [thread overview]
Message-ID: <431B2F6E.9070401@trash.net> (raw)
In-Reply-To: <431B2985.1060502@trash.net>
Patrick McHardy wrote:
> Herbert Xu wrote:
>
>> We aren't handling the reading of specific fields like the IP protocol
>> field correctly. This patch should make it work again.
>
>
> I can't spot the problem, could you give me a hint?
Never mind, I got it, we never fall through to the second switch
statement anymore. I think we could simply break when load_pointer
returns NULL. The switch statement will fall through to the default
case and return 0 for all cases but 0 > k >= SKF_AD_OFF.
next prev parent reply other threads:[~2005-09-04 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050902184416.GA6468@localhost.localdomain>
2005-09-03 0:27 ` Kernel 2.6.13 breaks libpcap (and tcpdump) Andrew Morton
2005-09-04 8:21 ` Herbert Xu
2005-09-04 17:06 ` Patrick McHardy
2005-09-04 17:31 ` Patrick McHardy [this message]
2005-09-04 22:09 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=431B2F6E.9070401@trash.net \
--to=kaber@trash.net \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jmcgowan@inch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).