From: Jeff Garzik <jgarzik@pobox.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>, Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH] 3c59x: read current link status from phy
Date: Wed, 07 Sep 2005 21:49:13 -0400 [thread overview]
Message-ID: <431F9899.4060602@pobox.com> (raw)
In-Reply-To: <200509080125.j881PcL9015847@hera.kernel.org>
Linux Kernel Mailing List wrote:
> tree 1771b690cdee80312ace3fe046e29e965a0b30eb
> parent c8d127418d78aaeeb1a417ef7453dc09c9118146
> author Tommy S. Christensen <tommy.christensen@tpack.net> Wed, 07 Sep 2005 05:17:28 -0700
> committer Linus Torvalds <torvalds@g5.osdl.org> Thu, 08 Sep 2005 06:57:30 -0700
>
> [PATCH] 3c59x: read current link status from phy
>
> The phy status register must be read twice in order to get the actual link
> state.
>
> Signed-off-by: Tommy S. Christensen <tommy.christensen@tpack.net>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
>
> drivers/net/3c59x.c | 1 +
> 1 files changed, 1 insertion(+)
>
> diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c
> --- a/drivers/net/3c59x.c
> +++ b/drivers/net/3c59x.c
> @@ -1889,6 +1889,7 @@ vortex_timer(unsigned long data)
> {
> spin_lock_bh(&vp->lock);
> mii_status = mdio_read(dev, vp->phys[0], 1);
> + mii_status = mdio_read(dev, vp->phys[0], 1);
It would be nice if somebody would be motivated to check in
s/1/MII_BMSR/ to utilize the constant in include/linux/mii.h.
Jeff
next parent reply other threads:[~2005-09-08 1:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200509080125.j881PcL9015847@hera.kernel.org>
2005-09-08 1:49 ` Jeff Garzik [this message]
2005-09-08 11:58 ` [PATCH] 3c59x: read current link status from phy Bogdan Costescu
2005-09-08 13:05 ` Tommy Christensen
2005-09-08 13:35 ` Bogdan Costescu
2005-09-08 14:42 ` Tommy Christensen
2005-09-08 15:42 ` Bogdan Costescu
2005-09-08 18:56 ` Andy Fleming
2005-09-09 10:10 ` Bogdan Costescu
2005-09-09 18:08 ` Andy Fleming
2005-09-08 22:39 ` Tommy Christensen
2005-09-08 22:41 ` Andrew Morton
2005-09-08 23:12 ` Tommy Christensen
2005-09-09 0:01 ` Jeff Garzik
2005-09-09 1:08 ` John W. Linville
2005-09-09 7:34 ` Tommy Christensen
2005-09-09 7:44 ` Andrew Morton
2005-09-09 11:35 ` Neil Horman
2005-09-08 14:13 ` [PATCH] 3c59x: cleanup of mdio_read routines to use MII_* macros in include/linux/mii.h Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=431F9899.4060602@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).