Re: [PATCH, netfilter] NUMA aware ipv4/netfilter/ip_tables.c

[Eric Dumazet <dada1@cosmosbay.com>]

Eric dumazet a écrit :
> Hi
> 
> Part of the performance problem we have with netfilter  is memory 
> allocation is not NUMA aware, but 'only' SMP aware.
> 
> What do you think of this patch ?
> 

...

> +#ifdef CONFIG_NUMA
> +		set_cpus_allowed(current, oldmask);
> +		mpol_free(current->mempolicy);
> +		current->mempolicy = oldpol;
> +#endif
> +		if (newinfo->entries[cpu] == 0) {
> +			free_table_info(newinfo);
> +			return NULL;
> +		if (!newinfo->entry0)
> +			newinfo->entry0 = newinfo->entries[cpu];
> +		}   // ERROR
> +	}
> +	return newinfo;
> +}
> +

Oops sorry for this misplaced brace. It should be :

 > +#ifdef CONFIG_NUMA
 > +		set_cpus_allowed(current, oldmask);
 > +		mpol_free(current->mempolicy);
 > +		current->mempolicy = oldpol;
 > +#endif
 > +		if (newinfo->entries[cpu] == 0) {
 > +			free_table_info(newinfo);
 > +			return NULL;
 > +             } // HERE
 > +		if (!newinfo->entry0)
 > +			newinfo->entry0 = newinfo->entries[cpu];
 > +	}
 > +	return newinfo;
 > +}
 > +