From: Jeff Garzik <jgarzik@pobox.com>
To: Andrew Morton <akpm@osdl.org>, Florin Malita <fmalita@gmail.com>
Cc: linux-kernel@vger.kernel.org, ctindel@users.sourceforge.net,
fubar@us.ibm.com, "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] bond_main.c: fix device deregistration in init exception path
Date: Wed, 21 Sep 2005 22:38:26 -0400 [thread overview]
Message-ID: <43321922.70707@pobox.com> (raw)
In-Reply-To: <20050917233224.2d4b3652.akpm@osdl.org>
Andrew Morton wrote:
> diff -puN drivers/net/bonding/bond_main.c~bond_mainc-fix-device-deregistration-in-init-exception drivers/net/bonding/bond_main.c
> --- devel/drivers/net/bonding/bond_main.c~bond_mainc-fix-device-deregistration-in-init-exception 2005-09-17 23:18:38.000000000 -0700
> +++ devel-akpm/drivers/net/bonding/bond_main.c 2005-09-17 23:31:02.000000000 -0700
> @@ -5039,6 +5039,14 @@ static int __init bonding_init(void)
> return 0;
>
> out_err:
> + /*
> + * rtnl_unlock() will run netdev_run_todo(), putting the
> + * thus-far-registered bonding devices into a state which
> + * unregigister_netdevice() will accept
> + */
> + rtnl_unlock();
> + rtnl_lock();
> +
Don't we want a schedule() or schedule_timeout(1) in between?
Jeff
next prev parent reply other threads:[~2005-09-22 2:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <432D0612.7070408@gmail.com>
2005-09-18 6:32 ` [PATCH] bond_main.c: fix device deregistration in init exception path Andrew Morton
2005-09-18 7:25 ` David S. Miller
2005-09-22 2:38 ` Jeff Garzik [this message]
2005-09-22 2:42 ` Andrew Morton
2005-09-22 2:43 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43321922.70707@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=ctindel@users.sourceforge.net \
--cc=davem@davemloft.net \
--cc=fmalita@gmail.com \
--cc=fubar@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).