netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Harald Welte <laforge@netfilter.org>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
	Patrick McHardy <kaber@sunbeam.de.gnumonks.org>,
	Netfilter Development Mailinglist
	<netfilter-devel@lists.netfilter.org>,
	David Miller <davem@davemloft.net>
Subject: Re: [PATCH/RFC] [NETFILTER]: Fix invalid module autoloading by splitting iptable_nat
Date: Sun, 25 Sep 2005 18:26:28 +0200	[thread overview]
Message-ID: <4336CFB4.6060806@trash.net> (raw)
In-Reply-To: <20050925150755.GK731@sunbeam.de.gnumonks.org>

Harald Welte wrote:
> Hi Patrick, Dave,
> 
> I think we really need a solution for the last (known) remaining
> dependency problem with 2.6.14.  Please see the description
> below.  I _think_ the patch is fine, at least I couldn't find any case
> where we could leak anything by splitting the code in two modules.
> 
> There's a slight semantic change, though.  If the user unloads
> iptable_nat, all existing connections (including their configured NAT
> mappings) will continue to work.  Only when ip_nat.ko is unloaded, the
> NAT mappings are evicted from the conntrack table.  I like it that way,
> since it's logical.

I agree, its more logical than having the table and the conntrack
part in one module.

  reply	other threads:[~2005-09-25 16:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-25 15:07 [PATCH/RFC] [NETFILTER]: Fix invalid module autoloading by splitting iptable_nat Harald Welte
2005-09-25 16:26 ` Patrick McHardy [this message]
2005-09-25 16:44   ` Harald Welte
2005-09-26 22:25     ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4336CFB4.6060806@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=kaber@sunbeam.de.gnumonks.org \
    --cc=laforge@netfilter.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).