netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fix ipv6 fragment ID selection at slow path
@ 2005-10-02 14:21 Yan Zheng
  2005-10-03  0:18 ` Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: Yan Zheng @ 2005-10-02 14:21 UTC (permalink / raw)
  To: linux-kernel, netdev, roque

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 332 bytes --]

--- linux-2.6.13.2/net/ipv6/ip6_output.c	2005-09-17 09:02:12.000000000 +0800
+++ linux/net/ipv6/ip6_output.c	2005-10-02 22:12:54.000000000 +0800
@@ -701,7 +701,7 @@
 		 */
 		fh->nexthdr = nexthdr;
 		fh->reserved = 0;
-		if (frag_id) {
+		if (!frag_id) {
 			ipv6_select_ident(skb, fh);
 			frag_id = fh->identification;
 		} else

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fix ipv6 fragment ID selection at slow path
  2005-10-02 14:21 [PATCH] fix ipv6 fragment ID selection at slow path Yan Zheng
@ 2005-10-03  0:18 ` Herbert Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2005-10-03  0:18 UTC (permalink / raw)
  To: Yan Zheng; +Cc: linux-kernel, netdev, roque

Yan Zheng <yzcorp@gmail.com> wrote:
> 
> --- linux-2.6.13.2/net/ipv6/ip6_output.c        2005-09-17 09:02:12.000000000 +0800
> +++ linux/net/ipv6/ip6_output.c 2005-10-02 22:12:54.000000000 +0800
> @@ -701,7 +701,7 @@
>                 */
>                fh->nexthdr = nexthdr;
>                fh->reserved = 0;
> -               if (frag_id) {
> +               if (!frag_id) {
>                        ipv6_select_ident(skb, fh);
>                        frag_id = fh->identification;
>                } else

This patch makes sense to me.

Please add a Signed-off-by line and send the patch to
davem@davemloft.net and yoshfuji@linux-ipv6.org.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-10-03  0:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-02 14:21 [PATCH] fix ipv6 fragment ID selection at slow path Yan Zheng
2005-10-03  0:18 ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).