From: Mohsin Bashir <mohsin.bashr@gmail.com>
To: Tariq Toukan <ttoukan.linux@gmail.com>, netdev@vger.kernel.org
Cc: alexanderduyck@fb.com, alok.a.tiwari@oracle.com,
andrew+netdev@lunn.ch, andrew@lunn.ch, davem@davemloft.net,
dg573847474@gmail.com, donald.hunter@gmail.com,
edumazet@google.com, gal@nvidia.com, horms@kernel.org,
idosch@nvidia.com, jacob.e.keller@intel.com,
kernel-team@meta.com, kory.maincent@bootlin.com, kuba@kernel.org,
lee@trager.us, leon@kernel.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org, linux@armlinux.org.uk,
mbloch@nvidia.com, mike.marciniszyn@gmail.com,
o.rempel@pengutronix.de, pabeni@redhat.com, saeedm@nvidia.com,
tariqt@nvidia.com, vadim.fedorenko@linux.dev
Subject: Re: [net-next V4 5/5] eth: mlx5: Move pause storm errors to pause stats
Date: Thu, 5 Mar 2026 07:43:08 -0800 [thread overview]
Message-ID: <43433a0f-f063-4b12-ad3a-16bd6aa9cc31@gmail.com> (raw)
In-Reply-To: <d02ac6b1-7322-49d9-881d-126b3a8d1d17@gmail.com>
On 3/5/26 6:12 AM, Tariq Toukan wrote:
> If we return here, tx_pause_storm_events remains unset, while rx/
> tx_pause_frames are already assigned.
> Is that acceptable? I'm probably fine with it.
Right. Since we are aggregating across all prio and if we fail
mid-flight, IMO, we should not report partial sum which maybe inaccurate.
next prev parent reply other threads:[~2026-03-05 15:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 23:01 [net-next V4 0/5] net: ethtool: Track TX pause storm Mohsin Bashir
2026-03-02 23:01 ` [net-next V4 1/5] net: ethtool: Track pause storm events Mohsin Bashir
2026-03-02 23:01 ` [net-next V4 2/5] net: ethtool: Update doc for tunable Mohsin Bashir
2026-03-02 23:01 ` [net-next V4 3/5] eth: fbnic: Add protection against pause storm Mohsin Bashir
2026-03-02 23:01 ` [net-next V4 4/5] eth: fbnic: Fetch TX pause storm stats Mohsin Bashir
2026-03-02 23:01 ` [net-next V4 5/5] eth: mlx5: Move pause storm errors to pause stats Mohsin Bashir
2026-03-05 11:26 ` Paolo Abeni
2026-03-05 14:12 ` Tariq Toukan
2026-03-05 15:43 ` Mohsin Bashir [this message]
2026-03-05 15:40 ` [net-next V4 0/5] net: ethtool: Track TX pause storm patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43433a0f-f063-4b12-ad3a-16bd6aa9cc31@gmail.com \
--to=mohsin.bashr@gmail.com \
--cc=alexanderduyck@fb.com \
--cc=alok.a.tiwari@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dg573847474@gmail.com \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=kernel-team@meta.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=lee@trager.us \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mbloch@nvidia.com \
--cc=mike.marciniszyn@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=ttoukan.linux@gmail.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox