[PATCH] skge support for Marvell chips in Toshiba laptops

[PATCH] skge support for Marvell chips in Toshiba laptops

[Jesse Barnes]

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

Here's a small patch to add the PCI ID and chip type of the chip in my 
Toshiba laptop to the skge driver.  I haven't tested it much (just 
insmoded it and run ethtool against the corresponding eth1 device), but 
it doesn't crash my system, so unless this configuration has already 
been tested and is known to have problems, it might be good to add this 
patch.

I'll test some more with a real network when I get home.

Thanks,
Jesse

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>


[-- Attachment #2: skge-toshiba.patch --]
[-- Type: text/x-diff, Size: 816 bytes --]

--- linux-2.6.14-rc4.orig/drivers/net/skge.c	2005-10-10 18:19:19.000000000 -0700
+++ linux-2.6.14-rc4/drivers/net/skge.c	2005-10-19 10:40:56.000000000 -0700
@@ -77,6 +77,7 @@
 	{ PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_YU) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, PCI_DEVICE_ID_DLINK_DGE510T), },
 	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4320) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4351), },
 	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5005) }, /* Belkin */
 	{ PCI_DEVICE(PCI_VENDOR_ID_CNET, PCI_DEVICE_ID_CNET_GIGACARD) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_LINKSYS, PCI_DEVICE_ID_LINKSYS_EG1064) },
@@ -2932,6 +2933,7 @@
 	case CHIP_ID_YUKON:
 	case CHIP_ID_YUKON_LITE:
 	case CHIP_ID_YUKON_LP:
+	case CHIP_ID_YUKON_FE:
 		if (phy_type < SK_PHY_MARV_COPPER && pmd_type != 'S')
 			hw->copper = 1;
 

Re: [PATCH] skge support for Marvell chips in Toshiba laptops

[Daniel Drake]

Hi Jesse,

Jesse Barnes wrote:
> Here's a small patch to add the PCI ID and chip type of the chip in my 
> Toshiba laptop to the skge driver.  I haven't tested it much (just 
> insmoded it and run ethtool against the corresponding eth1 device), but 
> it doesn't crash my system, so unless this configuration has already 
> been tested and is known to have problems, it might be good to add this 
> patch.
> 
> I'll test some more with a real network when I get home.

The device ID you added (0x4351) is already claimed by the new sky2 driver.

Unless theres a mistake in sky2's device table, your laptop contains a 
Yukon-II adapter which is incompatible with the original Yukon chips (skge = 
Yukon, sky2 = Yukon-II).

On the other hand, I believe Stephen could do with some extra sky2 testing :)
You can find it in the latest -mm releases.

Daniel

Re: [PATCH] skge support for Marvell chips in Toshiba laptops

[Jesse Barnes]

On Wednesday, October 19, 2005 12:43 pm, Daniel Drake wrote:
> The device ID you added (0x4351) is already claimed by the new sky2
> driver.
>
> Unless theres a mistake in sky2's device table, your laptop contains a
> Yukon-II adapter which is incompatible with the original Yukon chips
> (skge = Yukon, sky2 = Yukon-II).
>
> On the other hand, I believe Stephen could do with some extra sky2
> testing :) You can find it in the latest -mm releases.

Oh cool, I'll try that driver instead.  Thanks.

Jesse

Re: [PATCH] skge support for Marvell chips in Toshiba laptops

[Krzysztof Oledzki]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1151 bytes --]



On Wed, 19 Oct 2005, Daniel Drake wrote:

> Hi Jesse,
>
> Jesse Barnes wrote:
>> Here's a small patch to add the PCI ID and chip type of the chip in my 
>> Toshiba laptop to the skge driver.  I haven't tested it much (just insmoded 
>> it and run ethtool against the corresponding eth1 device), but it doesn't 
>> crash my system, so unless this configuration has already been tested and 
>> is known to have problems, it might be good to add this patch.
>> 
>> I'll test some more with a real network when I get home.
>
> The device ID you added (0x4351) is already claimed by the new sky2 driver.
>
> Unless theres a mistake in sky2's device table, your laptop contains a 
> Yukon-II adapter which is incompatible with the original Yukon chips (skge = 
> Yukon, sky2 = Yukon-II).
>
> On the other hand, I believe Stephen could do with some extra sky2 testing :)
> You can find it in the latest -mm releases.

What is the name of sky2 driver? I can't to find it in:
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.14-rc4/2.6.14-rc4-mm1/broken-out/

Wrong place?

Best regards,

 			Krzysztof Olędzki

Re: [PATCH] skge support for Marvell chips in Toshiba laptops

[Daniel Drake]

Krzysztof Oledzki wrote:
> What is the name of sky2 driver? I can't to find it in:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.14-rc4/2.6.14-rc4-mm1/broken-out/ 
> 
> 
> Wrong place?

Its pulled in from the netdev tree.

Daniel