netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bernard Pidoux <pidoux@ccr.jussieu.fr>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Arnaldo Carvalho de Melo <acme@conectiva.com.br>,
	dann frazier <dannf@hp.com>,
	chrisw@osdl.org, netdev@vger.kernel.org,
	linux-hams@vger.kernel.org, Jean-Paul ROUBELAT <jpr@f6fbb.org>
Subject: af_rose.c
Date: Fri, 21 Oct 2005 00:12:50 +0200	[thread overview]
Message-ID: <43581662.7040208@ccr.jussieu.fr> (raw)
In-Reply-To: <20051018203932.GA11053@linux-mips.org>

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]

Hi,

Concerning rose module, here is a patch proposed by Jean-Paul F6FBB for 
af_rose.c

It is against linux-2.6.14-rc5

This patch only adds a loop near the end of rose_connect() in order to 
make it try to connect rose next_neighbour node in case of connect 
failure, until we reach the true end of the neighbour list.

With the guys of FADCA and other french hams using ROSE/FPAC we found 
that ROSE did not scan the alternate routes even when there was one 
available.

This could be an important point in case of catastrophic events with 
telecommunication failure. The possibility to handle emergency traffic 
via alternate routes could be a vital necessity.

The principle of this patch has been tested with kernel 2.2 and 2.6 and 
it works well using F6FBB ROSE/FPAC packet switch application.

I suggest that it should be included into the next kernel rose module.

73 de Bernard, f6bvp


[-- Attachment #2: af_rose.c.2.6.14-rc5.diff --]
[-- Type: text/x-patch, Size: 701 bytes --]

--- net/rose/af_rose.c	2005-10-20 23:27:15.000000000 +0200
+++ net/rose/af_rose.c	2005-10-20 23:38:20.000000000 +0200
@@ -751,7 +751,7 @@
 
 		rose_insert_socket(sk);		/* Finish the bind */
 	}
-
+rose_try_next_neigh:
 	rose->dest_addr   = addr->srose_addr;
 	rose->dest_call   = addr->srose_call;
 	rose->rand        = ((long)rose & 0xFFFF) + rose->lci;
@@ -809,6 +809,11 @@
 	}
 
 	if (sk->sk_state != TCP_ESTABLISHED) {
+	/* Try next neighbour */
+		rose->neighbour = rose_get_neigh(&addr->srose_addr, &cause, &diagnostic);
+		if (rose->neighbour)
+			goto rose_try_next_neigh;
+	/* No more neighbour */
 		sock->state = SS_UNCONNECTED;
 		return sock_error(sk);	/* Always set at this point */
 	}

  reply	other threads:[~2005-10-20 22:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-18 20:39 [PATCH] AX.25: Use constant instead of magic number Ralf Baechle
2005-10-20 22:12 ` Bernard Pidoux [this message]
2005-10-28 22:47 ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43581662.7040208@ccr.jussieu.fr \
    --to=pidoux@ccr.jussieu.fr \
    --cc=acme@conectiva.com.br \
    --cc=chrisw@osdl.org \
    --cc=dannf@hp.com \
    --cc=davem@davemloft.net \
    --cc=jpr@f6fbb.org \
    --cc=linux-hams@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).