From: Jeff Garzik <jgarzik@pobox.com>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Ayaz Abdulla <AAbdulla@nvidia.com>, Netdev <netdev@oss.sgi.com>
Subject: Re: [PATCH 3/2] forcedeth: Compile fix forcedeth 0.44
Date: Fri, 21 Oct 2005 17:23:37 -0400 [thread overview]
Message-ID: <43595C59.7070204@pobox.com> (raw)
In-Reply-To: <432D771D.7050107@colorfullife.com>
Manfred Spraul wrote:
> Hi,
>
> forcedeth-0.44 contains a spurious ; in nv_release_txskb. gcc-4 compiles
> it with a warning, older compilers might reject it.
> The attached onliner fixes that, sorry.
>
> Signed-off-By: Manfred Spraul <manfred@colorfullife.com>
>
>
> ------------------------------------------------------------------------
>
> --- 2.6/drivers/net/forcedeth.c 2005-09-18 16:12:10.000000000 +0200
> +++ build-2.6/drivers/net/forcedeth.c 2005-09-18 16:14:19.000000000 +0200
> @@ -923,7 +923,7 @@ static int nv_init_ring(struct net_devic
> static void nv_release_txskb(struct net_device *dev, unsigned int skbnr)
> {
> struct fe_priv *np = get_nvpriv(dev);
> - struct sk_buff *skb = np->tx_skbuff[skbnr];;
> + struct sk_buff *skb = np->tx_skbuff[skbnr];
> unsigned int j, entry, fragments;
obviously OK, but dropped since the previous patch was dropped
prev parent reply other threads:[~2005-10-21 21:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-18 14:18 [PATCH 3/2] forcedeth: Compile fix forcedeth 0.44 Manfred Spraul
2005-10-21 21:23 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43595C59.7070204@pobox.com \
--to=jgarzik@pobox.com \
--cc=AAbdulla@nvidia.com \
--cc=manfred@colorfullife.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).