* [PATCH 3/2] forcedeth: Compile fix forcedeth 0.44
@ 2005-09-18 14:18 Manfred Spraul
2005-10-21 21:23 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Manfred Spraul @ 2005-09-18 14:18 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Ayaz Abdulla, Netdev
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
Hi,
forcedeth-0.44 contains a spurious ; in nv_release_txskb. gcc-4 compiles
it with a warning, older compilers might reject it.
The attached onliner fixes that, sorry.
Signed-off-By: Manfred Spraul <manfred@colorfullife.com>
[-- Attachment #2: patch-forcedeth-044a-compilefix --]
[-- Type: text/plain, Size: 521 bytes --]
--- 2.6/drivers/net/forcedeth.c 2005-09-18 16:12:10.000000000 +0200
+++ build-2.6/drivers/net/forcedeth.c 2005-09-18 16:14:19.000000000 +0200
@@ -923,7 +923,7 @@ static int nv_init_ring(struct net_devic
static void nv_release_txskb(struct net_device *dev, unsigned int skbnr)
{
struct fe_priv *np = get_nvpriv(dev);
- struct sk_buff *skb = np->tx_skbuff[skbnr];;
+ struct sk_buff *skb = np->tx_skbuff[skbnr];
unsigned int j, entry, fragments;
dprintk(KERN_INFO "%s: nv_release_txskb for skbnr %d, skb %p\n",
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 3/2] forcedeth: Compile fix forcedeth 0.44
2005-09-18 14:18 [PATCH 3/2] forcedeth: Compile fix forcedeth 0.44 Manfred Spraul
@ 2005-10-21 21:23 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2005-10-21 21:23 UTC (permalink / raw)
To: Manfred Spraul; +Cc: Ayaz Abdulla, Netdev
Manfred Spraul wrote:
> Hi,
>
> forcedeth-0.44 contains a spurious ; in nv_release_txskb. gcc-4 compiles
> it with a warning, older compilers might reject it.
> The attached onliner fixes that, sorry.
>
> Signed-off-By: Manfred Spraul <manfred@colorfullife.com>
>
>
> ------------------------------------------------------------------------
>
> --- 2.6/drivers/net/forcedeth.c 2005-09-18 16:12:10.000000000 +0200
> +++ build-2.6/drivers/net/forcedeth.c 2005-09-18 16:14:19.000000000 +0200
> @@ -923,7 +923,7 @@ static int nv_init_ring(struct net_devic
> static void nv_release_txskb(struct net_device *dev, unsigned int skbnr)
> {
> struct fe_priv *np = get_nvpriv(dev);
> - struct sk_buff *skb = np->tx_skbuff[skbnr];;
> + struct sk_buff *skb = np->tx_skbuff[skbnr];
> unsigned int j, entry, fragments;
obviously OK, but dropped since the previous patch was dropped
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-10-21 21:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-18 14:18 [PATCH 3/2] forcedeth: Compile fix forcedeth 0.44 Manfred Spraul
2005-10-21 21:23 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).