From: Jeff Garzik <jgarzik@pobox.com>
To: Ayaz Abdulla <aabdulla@nvidia.com>
Cc: Stephen Hemminger <shemminger@osdl.org>,
Manfred Spraul <manfred@colorfullife.com>,
Netdev <netdev@oss.sgi.com>
Subject: Re: [PATCH 2/2] forcedeth: scatter gather and segmentation offload support
Date: Wed, 26 Oct 2005 00:53:09 -0400 [thread overview]
Message-ID: <435F0BB5.1070802@pobox.com> (raw)
In-Reply-To: <435D1464.3010203@nvidia.com>
Ayaz Abdulla wrote:
> Yes, forgot that indent.
>
> Here it is again with that fix.
I applied this version of the patch to the 'upstream' patch.
In the future, as Stephen noted, it would really be preferred that you
split up the patch into logical changes. patch 1/2 netdev_priv(), patch
2/2 SG support, for example.
Also, always include the Signed-off-by line, even on patch resends. See
http://linux.yyz.us/patch-format.html
for more info.
Jeff
next prev parent reply other threads:[~2005-10-26 4:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-18 14:01 [PATCH 2/2] forcedeth: scatter gather and segmentation offload support Manfred Spraul
2005-10-21 21:23 ` Jeff Garzik
2005-10-24 16:48 ` Ayaz Abdulla
2005-10-24 18:00 ` Stephen Hemminger
2005-10-24 17:05 ` Ayaz Abdulla
2005-10-26 4:53 ` Jeff Garzik [this message]
2005-10-24 21:21 ` Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2005-10-25 21:15 Ayaz Abdulla
2005-10-25 21:59 ` Francois Romieu
2005-10-25 20:30 ` Michael Chan
2005-10-25 23:22 ` Francois Romieu
2005-10-25 22:05 ` Michael Chan
2005-10-26 6:17 Ayaz Abdulla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=435F0BB5.1070802@pobox.com \
--to=jgarzik@pobox.com \
--cc=aabdulla@nvidia.com \
--cc=manfred@colorfullife.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).