From: Florian Fainelli <f.fainelli@gmail.com>
To: Benedikt Spranger <b.spranger@linutronix.de>, netdev@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] net: dsa: b53: Turn on managed mode and set IMP port
Date: Tue, 18 Jun 2019 11:10:14 -0700 [thread overview]
Message-ID: <435e5bde-2fc5-edd3-b757-9e5f8976bfe3@gmail.com> (raw)
In-Reply-To: <20190618175712.71148-2-b.spranger@linutronix.de>
On 6/18/19 10:57 AM, Benedikt Spranger wrote:
> From: Florian Fainelli <f.fainelli@gmail.com>
>
> When enabling Broadcom tags on earlier devices such as BCM53125, we need
> to also enable Managed mode, as well as configure which port is going to
> be the IMP port. If we did not do that, the switch would just pass
> through the Broadcom tags on the wire and not act on them. We need to
> have bcm_sf2 stop overwriting the SWMODE register and let b53 deal with
> that now.
>
> Fixes: 7edc58d614d4 ("net: dsa: b53: Turn on Broadcom tags")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Benedikt Spranger <b.spranger@linutronix.de>
This patch was part of a bigger series that you don't submit, so you are
simply not just potentially breaking all users of b53, but you are also
breaking bcm_sf2 which you probably don't have access to for testing,
that's unfortunate. More on the cover letter.
--
Florian
next prev parent reply other threads:[~2019-06-18 18:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 17:57 [RFC PATCH 0/2] enable broadcom tagging for bcm531x5 switches Benedikt Spranger
2019-06-18 17:57 ` [RFC PATCH 1/2] net: dsa: b53: Turn on managed mode and set IMP port Benedikt Spranger
2019-06-18 18:10 ` Florian Fainelli [this message]
2019-06-18 17:57 ` [RFC PATCH 2/2] net: dsa: b53: enbale broadcom tags on bcm531x5 Benedikt Spranger
2019-06-18 18:16 ` [RFC PATCH 0/2] enable broadcom tagging for bcm531x5 switches Florian Fainelli
2019-06-19 9:18 ` Benedikt Spranger
2019-06-23 2:24 ` Florian Fainelli
2019-06-25 11:20 ` Benedikt Spranger
2019-06-25 18:17 ` Florian Fainelli
2019-06-27 10:15 ` [RFC PATCH 0/1] Document the configuration of b53 Benedikt Spranger
2019-06-27 10:15 ` [RFC PATCH 1/1] Documentation: net: dsa: b53: Describe b53 configuration Benedikt Spranger
2019-06-27 13:49 ` Andrew Lunn
2019-06-27 14:43 ` Benedikt Spranger
2019-06-27 16:38 ` Florian Fainelli
2019-06-28 11:44 ` Kurt Kanzenbach
2019-06-28 16:57 ` Benedikt Spranger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=435e5bde-2fc5-edd3-b757-9e5f8976bfe3@gmail.com \
--to=f.fainelli@gmail.com \
--cc=b.spranger@linutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).