From: Michal Schmidt <xschmi00@stud.feec.vutbr.cz>
To: Bill Moss <bmoss@CLEMSON.EDU>
Cc: linville@tuxdriver.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.13] airo.c: remove delay in airo_get_scan
Date: Wed, 02 Nov 2005 22:29:31 +0100 [thread overview]
Message-ID: <43692FBB.1000409@stud.feec.vutbr.cz> (raw)
In-Reply-To: <200511020347.jA23lvi9028538@localhost.localdomain>
Bill Moss wrote:
> Remove 3 second delay in airo_get_scan. Testing shows this delay is unnecessary. Users of NetworkManager
> find this delay make NetworkManager slow to connect.
>
> --- a/drivers/net/wireless/airo.c 2005-11-01 21:21:04.000000000 -0500
> +++ b/drivers/net/wireless/airo.c 2005-11-01 21:22:41.000000000 -0500
> @@ -6918,7 +6918,7 @@
> /* When we are associated again, the scan has surely finished.
> * Just in case, let's make sure enough time has elapsed since
> * we started the scan. - Javier */
> - if(ai->scan_timestamp && time_before(jiffies,ai->scan_timestamp+3*HZ)) {
> + if(ai->scan_timestamp && time_before(jiffies,ai->scan_timestamp)) {
> /* Important note : we don't want to block the caller
> * until results are ready for various reasons.
> * First, managing wait queues is complex and racy
>
> Signed-off-by: Bill Moss <bmoss@clemson.edu>
With this change, the time_before() test can't possibly succeed, can it?
In that case, why not remove the if and its body completely?
Michal
prev parent reply other threads:[~2005-11-02 21:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-02 3:47 [PATCH 2.6.13] airo.c: remove delay in airo_get_scan Bill Moss
2005-11-02 21:29 ` Michal Schmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43692FBB.1000409@stud.feec.vutbr.cz \
--to=xschmi00@stud.feec.vutbr.cz \
--cc=bmoss@CLEMSON.EDU \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).