* [PATCH 2.6.13] airo.c: remove delay in airo_get_scan
@ 2005-11-02 3:47 Bill Moss
2005-11-02 21:29 ` Michal Schmidt
0 siblings, 1 reply; 2+ messages in thread
From: Bill Moss @ 2005-11-02 3:47 UTC (permalink / raw)
To: linville, netdev; +Cc: linux-kernel
Remove 3 second delay in airo_get_scan. Testing shows this delay is unnecessary. Users of NetworkManager
find this delay make NetworkManager slow to connect.
--- a/drivers/net/wireless/airo.c 2005-11-01 21:21:04.000000000 -0500
+++ b/drivers/net/wireless/airo.c 2005-11-01 21:22:41.000000000 -0500
@@ -6918,7 +6918,7 @@
/* When we are associated again, the scan has surely finished.
* Just in case, let's make sure enough time has elapsed since
* we started the scan. - Javier */
- if(ai->scan_timestamp && time_before(jiffies,ai->scan_timestamp+3*HZ)) {
+ if(ai->scan_timestamp && time_before(jiffies,ai->scan_timestamp)) {
/* Important note : we don't want to block the caller
* until results are ready for various reasons.
* First, managing wait queues is complex and racy
Signed-off-by: Bill Moss <bmoss@clemson.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.13] airo.c: remove delay in airo_get_scan
2005-11-02 3:47 [PATCH 2.6.13] airo.c: remove delay in airo_get_scan Bill Moss
@ 2005-11-02 21:29 ` Michal Schmidt
0 siblings, 0 replies; 2+ messages in thread
From: Michal Schmidt @ 2005-11-02 21:29 UTC (permalink / raw)
To: Bill Moss; +Cc: linville, netdev, linux-kernel
Bill Moss wrote:
> Remove 3 second delay in airo_get_scan. Testing shows this delay is unnecessary. Users of NetworkManager
> find this delay make NetworkManager slow to connect.
>
> --- a/drivers/net/wireless/airo.c 2005-11-01 21:21:04.000000000 -0500
> +++ b/drivers/net/wireless/airo.c 2005-11-01 21:22:41.000000000 -0500
> @@ -6918,7 +6918,7 @@
> /* When we are associated again, the scan has surely finished.
> * Just in case, let's make sure enough time has elapsed since
> * we started the scan. - Javier */
> - if(ai->scan_timestamp && time_before(jiffies,ai->scan_timestamp+3*HZ)) {
> + if(ai->scan_timestamp && time_before(jiffies,ai->scan_timestamp)) {
> /* Important note : we don't want to block the caller
> * until results are ready for various reasons.
> * First, managing wait queues is complex and racy
>
> Signed-off-by: Bill Moss <bmoss@clemson.edu>
With this change, the time_before() test can't possibly succeed, can it?
In that case, why not remove the if and its body completely?
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-11-02 21:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-02 3:47 [PATCH 2.6.13] airo.c: remove delay in airo_get_scan Bill Moss
2005-11-02 21:29 ` Michal Schmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).