From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Schmidt Subject: Re: [PATCH 2.6.13] airo.c: remove delay in airo_get_scan Date: Wed, 02 Nov 2005 22:29:31 +0100 Message-ID: <43692FBB.1000409@stud.feec.vutbr.cz> References: <200511020347.jA23lvi9028538@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linville@tuxdriver.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: To: Bill Moss In-Reply-To: <200511020347.jA23lvi9028538@localhost.localdomain> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Bill Moss wrote: > Remove 3 second delay in airo_get_scan. Testing shows this delay is unnecessary. Users of NetworkManager > find this delay make NetworkManager slow to connect. > > --- a/drivers/net/wireless/airo.c 2005-11-01 21:21:04.000000000 -0500 > +++ b/drivers/net/wireless/airo.c 2005-11-01 21:22:41.000000000 -0500 > @@ -6918,7 +6918,7 @@ > /* When we are associated again, the scan has surely finished. > * Just in case, let's make sure enough time has elapsed since > * we started the scan. - Javier */ > - if(ai->scan_timestamp && time_before(jiffies,ai->scan_timestamp+3*HZ)) { > + if(ai->scan_timestamp && time_before(jiffies,ai->scan_timestamp)) { > /* Important note : we don't want to block the caller > * until results are ready for various reasons. > * First, managing wait queues is complex and racy > > Signed-off-by: Bill Moss With this change, the time_before() test can't possibly succeed, can it? In that case, why not remove the if and its body completely? Michal