netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Knutsson <ricknu-0@student.ltu.se>
To: Ashutosh Naik <ashutosh.lkml@gmail.com>
Cc: netdev@vger.kernel.org, davej@suse.de, acme@conectiva.com.br,
	linux-net@vger.kernel.org, akpm@osdl.org,
	linux-kernel@vger.kernel.org, stable@kernel.org,
	trivial@rustcorp.com.au
Subject: [PATCH] /drivers/net/dgrs.c - Fixes Warnings when CONFIG_EISA or CONFIG_PCI are not enabled
Date: Fri, 04 Nov 2005 00:13:24 +0100	[thread overview]
Message-ID: <436A9994.1000201@student.ltu.se> (raw)
In-Reply-To: <c216304e0511022139j70614ae3l3a96767c0a36358e@mail.gmail.com>


>>>>>This patch fixes compiler warnings when CONFIG_ISA and CONFIG_PCI are
>>>>>not enabled in the dgrc network driver.
>>>>>
>>>>>Signed-off-by: Ashutosh Naik <ashutosh.naik@gmail.com>	
>>>>>
>>>>>--
>>>>>diff -Naurp linux-2.6.14/drivers/net/dgrs.c
>>>>>linux-2.6.14-git1/drivers/net/dgrs.c---
>>>>>linux-2.6.14/drivers/net/dgrs.c     2005-10-28 05:32:08.000000000
>>>>>+0530
>>>>>+++ linux-2.6.14-git1/drivers/net/dgrs.c        2005-11-01
>>>>>10:30:03.000000000 +0530
>>>>>@@ -1549,8 +1549,12 @@ MODULE_PARM_DESC(nicmode, "Digi RightSwi
>>>>>static int __init dgrs_init_module (void)  {
>>>>>      int     i;
>>>>>-       int eisacount = 0, pcicount = 0;
>>>>>-
>>>>>+#ifdef CONFIG_EISA
>>>>>+       int eisacount = 0;
>>>>>+#endif
>>>>>+#ifdef CONFIG_PCI
>>>>>+       int pcicount = 0;
>>>>>+#endif
>>>>>      /*
>>>>>       *      Command line variable overrides
>>>>>       *              debug=NNN
>>>>>          
>>>>>
>
>Both CONFIG_PCI and CONFIG_EISA cant be undefined at the same time,
>because the device has to be on either of the 2 busses. I think your
>patch is better in that case.
>
>Cheers
>Ashutosh
>  
>
OK, then I send in the patch again. Thanks for your help/opinion.

Till the next time...
/Richard

<--  snip  -->

This patch fixes compiler warnings when CONFIG_ISA or CONFIG_PCI are not enabled in the dgrc network driver.

Cleanly patched to 2.6.14-git6.

Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>

---

diff -Nurp a/drivers/net/dgrs.c b/drivers/net/dgrs.c
--- a/drivers/net/dgrs.c	2005-10-28 02:02:08.000000000 +0200
+++ b/drivers/net/dgrs.c	2005-11-02 10:19:43.000000000 +0100
@@ -1549,7 +1549,7 @@ MODULE_PARM_DESC(nicmode, "Digi RightSwi
 static int __init dgrs_init_module (void)
 {
 	int	i;
-	int eisacount = 0, pcicount = 0;
+	int	count;
 
 	/*
 	 *	Command line variable overrides
@@ -1591,14 +1591,14 @@ static int __init dgrs_init_module (void
 	 *	Find and configure all the cards
 	 */
 #ifdef CONFIG_EISA
-	eisacount = eisa_driver_register(&dgrs_eisa_driver);
-	if (eisacount < 0)
-		return eisacount;
+	count = eisa_driver_register(&dgrs_eisa_driver);
+	if (count < 0)
+		return count;
 #endif
 #ifdef CONFIG_PCI
-	pcicount = pci_register_driver(&dgrs_pci_driver);
-	if (pcicount)
-		return pcicount;
+	count = pci_register_driver(&dgrs_pci_driver);
+	if (count)
+		return count;
 #endif
 	return 0;
 }



  reply	other threads:[~2005-11-03 23:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <81083a450511012314q4ec69927gfa60cb19ba8f437a@mail.gmail.com>
     [not found] ` <4368878D.4040406@student.ltu.se>
     [not found]   ` <c216304e0511020516o5cfcd0b9u96a3220bf2694928@mail.gmail.com>
2005-11-02 20:55     ` [PATCH]dgrs - Fixes Warnings when CONFIG_ISA and CONFIG_PCI are not enabled Richard Knutsson
2005-11-03  5:39       ` Ashutosh Naik
2005-11-03 23:13         ` Richard Knutsson [this message]
2005-11-05  2:25       ` Andrew Morton
2005-11-05  2:30         ` Andrew Morton
2005-11-05  4:51           ` Ashutosh Naik
2005-11-05  8:36           ` Richard Knutsson
2005-11-05  8:46             ` Andrew Morton
2005-11-05 11:54               ` Richard Knutsson
2005-11-05 15:29                 ` Richard Knutsson
2005-11-05 17:45                   ` Andrew Morton
2005-11-05 17:46                 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=436A9994.1000201@student.ltu.se \
    --to=ricknu-0@student.ltu.se \
    --cc=acme@conectiva.com.br \
    --cc=akpm@osdl.org \
    --cc=ashutosh.lkml@gmail.com \
    --cc=davej@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stable@kernel.org \
    --cc=trivial@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).