From: Patrick McHardy <kaber@trash.net>
To: Adrian Bunk <bunk@stusta.de>
Cc: Christian <evil@g-house.de>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Roman Zippel <zippel@linux-m68k.org>
Subject: Re: [2.6 patch] do not select NET_CLS
Date: Mon, 21 Nov 2005 17:16:18 +0100 [thread overview]
Message-ID: <4381F2D2.5000605@trash.net> (raw)
In-Reply-To: <20051121155955.GW16060@stusta.de>
Adrian Bunk wrote:
> 2.6.15-rc changes NET_CLS to being automatically select'ed when needed.
>
> This patch confuses users since NET_CLS is a bool, and compiling an
> additional module that select's NET_CLS causes unresolved symbols since
> it's not user-visible that adding a module changes the kernel image.
>
> This patch therefore changes NET_CLS back to the 2.6.14 status quo of
> being an user-visible option.
I disagree with this patch. NET_CLS enables the infrastructure support
for classifiers. Users generally don't care about infrastructure but
directly usable things, so I'd prefer to have it automatically selected.
And there are lots of other cases where enabling a module causes changes
in the kernel image. Some examples include some of the netfilter stuff,
the IPsec transforms, NET_CLS_ROUTE4, the ieee80211 stuff, and a lot
more.
next prev parent reply other threads:[~2005-11-21 16:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <437BBC59.70301@g-house.de>
2005-11-16 23:58 ` 2.6.15-rc1: NET_CLS_U32 not working? Adrian Bunk
2005-11-17 0:06 ` Christian
2005-11-17 15:57 ` Christian
2005-11-21 15:59 ` [2.6 patch] do not select NET_CLS Adrian Bunk
2005-11-21 16:16 ` Patrick McHardy [this message]
2005-11-22 22:37 ` David S. Miller
2005-11-22 22:49 ` Sam Ravnborg
2005-11-22 23:00 ` David S. Miller
2005-11-23 5:57 ` Sam Ravnborg
2005-11-24 2:13 ` Randy.Dunlap
2005-11-24 5:40 ` Sam Ravnborg
2005-11-22 23:12 ` Adrian Bunk
2005-11-23 10:27 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4381F2D2.5000605@trash.net \
--to=kaber@trash.net \
--cc=bunk@stusta.de \
--cc=evil@g-house.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).