From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B676F2D595F for ; Fri, 17 Oct 2025 10:22:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760696548; cv=none; b=CNaWQKTBshyOKfxtgtK/w3qDzSpRhHtpZK8V/ictql58h6A06Yn8fnsSI//E8A5UM3B5P59hx8klCMRLYMoZ0BiUhUz4ZPHt3wv8y3TrLSIVB6R+P+KGJClxvJdZ3+InLa0Wds/95TJAXSXI8xHoaRN4Tdwir8oCtbEsWb90fOs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760696548; c=relaxed/simple; bh=LTAr1hY9HCJyR9LS20fLPV2AY9+9mh+4PjZlB1H/b04=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SMB/F9ZnqCMwnFFuA/91khHftzXlTEAqJWtEBRVln9ghkOVtECrFhruq3PemQY8WdoZxsI/efYpGQtK+w8kLyAlkOnBR/vCk6/HE8H5ROVncSWkG5PzhnoqWu9u63h7eLvqvF8i7dyo1voBIkcsBFZKP6Xhe+SI7ymmnLhezC2s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=wKH0rRrt; arc=none smtp.client-ip=95.215.58.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="wKH0rRrt" Message-ID: <438f350d-df66-4d51-8827-c686ef0f8da9@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1760696534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M7LSmPEchHZRoXeuYfgrqGXC5NdIshmVzOumLFM3Pgk=; b=wKH0rRrtB4vow9oxFnRDGJZ1EQNHsicS7o1uaefQBLONOA4+wLYvu5BTXxcrvyckvryCUk PBlT1wlw2UqJJEpgM3kr7HVw6zlpmqV9n1OE0dziJUNB/9X35S/t2WmWO2nGBCjMnazMAH UvqwuiiUW0PsGHeyBI0Ua8llyZl2yrg= Date: Fri, 17 Oct 2025 11:22:06 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next 6/6] net: hns3: add hwtstamp_get/hwtstamp_set ops To: Simon Horman Cc: Jian Shen , Salil Mehta , Jijie Shao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sunil Goutham , Geetha sowjanya , Subbaraya Sundeep , Bharat Bhushan , Tariq Toukan , Brett Creeley , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Paul Barker , Yoshihiro Shimoda , linux-renesas-soc@vger.kernel.org, Richard Cochran , Russell King , Vladimir Oltean , Jacob Keller , netdev@vger.kernel.org References: <20251016180727.3511399-1-vadim.fedorenko@linux.dev> <20251016180727.3511399-7-vadim.fedorenko@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 17/10/2025 10:15, Simon Horman wrote: > On Thu, Oct 16, 2025 at 06:07:27PM +0000, Vadim Fedorenko wrote: > > ... > >> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c >> index bfa5568baa92..1e9388f1115c 100644 >> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c >> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c >> @@ -2419,6 +2419,35 @@ static int hns3_nic_do_ioctl(struct net_device *netdev, >> return h->ae_algo->ops->do_ioctl(h, ifr, cmd); >> } >> >> +static int hns3_nic_hwtstamp_get(struct net_device *netdev, >> + struct kernel_hwtstamp_config *config) >> +{ >> + struct hnae3_handle *h = hns3_get_handle(netdev); >> + >> + if (!netif_running(netdev)) >> + return -EINVAL; >> + >> + if (!h->ae_algo->ops->hwtstamp_get) >> + return -EOPNOTSUPP; >> + >> + return h->ae_algo->ops->hwtstamp_get(h, config); >> +} >> + >> +static int hns3_nic_hwtstamp_set(struct net_device *netdev, >> + struct kernel_hwtstamp_config *config, >> + struct netlink_ext_ack *extack) >> +{ >> + struct hnae3_handle *h = hns3_get_handle(netdev); >> + >> + if (!netif_running(netdev)) >> + return -EINVAL; >> + >> + if (!h->ae_algo->ops->hwtstamp_set) >> + return -EOPNOTSUPP; >> + >> + return h->ae_algo->ops->hwtstamp_set(h, config, extack); >> +} >> + >> static int hns3_nic_set_features(struct net_device *netdev, >> netdev_features_t features) >> { > > Hi Vadim, > > I'm sorry to raise this topic again. > But I see the functions above flagged as unused with > this patch applied (for allmodconfig builds). > > ... Hi Simon, looks like actual .ndo_hwtstamp_get/.ndo_hwtstamp_set initialization is missing... dunno how that happened, but v2 will be on the list once 24h wait period is passed. Thanks for flagging the issue!