From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Fan Gong <gongfan1@huawei.com>,
Zhu Yikai <zhuyikai1@h-partners.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
luosifu <luosifu@huawei.com>, Xin Guo <guoxin09@huawei.com>,
Zhou Shuai <zhoushuai28@huawei.com>, Wu Like <wulike1@huawei.com>,
Shi Jing <shijing34@huawei.com>,
Zheng Jiezhen <zhengjiezhen@h-partners.com>
Subject: Re: [PATCH net-next v01 5/7] hinic3: Add MTU size validation
Date: Fri, 13 Mar 2026 09:50:26 +0100 [thread overview]
Message-ID: <439753dc-496d-4e03-8480-ea409fb3d4bd@bootlin.com> (raw)
In-Reply-To: <53eb2c11ed4ccd93787352ef48ca56d6d51a150a.1773387649.git.zhuyikai1@h-partners.com>
Hi,
On 13/03/2026 08:54, Fan Gong wrote:
> Check whether the MTU size is within a reasonable range.
I don't get why this is needed when we have netdev->min_mtu and
netdev->max_mtu already to sanitize these parameters.
Is this patch needed, and if so can you explain why the
netdev->min/max_mtu parameters aren't enough ?
Maxime
next prev parent reply other threads:[~2026-03-13 8:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 7:54 [PATCH net-next v01 0/7] net: hinic3: PF initialization Fan Gong
2026-03-13 7:54 ` [PATCH net-next v01 1/7] hinic3: Add ethtool queue ops Fan Gong
2026-03-13 7:54 ` [PATCH net-next v01 2/7] hinic3: Add ethtool statistic ops Fan Gong
2026-03-13 8:31 ` Maxime Chevallier
2026-03-13 14:36 ` Ioana Ciornei
2026-03-13 7:54 ` [PATCH net-next v01 3/7] hinic3: Add ethtool coalesce ops Fan Gong
2026-03-13 7:54 ` [PATCH net-next v01 4/7] hinic3: Add ethtool rss ops Fan Gong
2026-03-13 7:54 ` [PATCH net-next v01 5/7] hinic3: Add MTU size validation Fan Gong
2026-03-13 8:50 ` Maxime Chevallier [this message]
2026-03-16 1:54 ` Fan Gong
2026-03-13 7:54 ` [PATCH net-next v01 6/7] hinic3: Configure netdev->watchdog_timeo to set nic tx timeout Fan Gong
2026-03-13 7:54 ` [PATCH net-next v01 7/7] hinic3: Remove unneed coalesce parameters Fan Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=439753dc-496d-4e03-8480-ea409fb3d4bd@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gongfan1@huawei.com \
--cc=guoxin09@huawei.com \
--cc=horms@kernel.org \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luosifu@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shijing34@huawei.com \
--cc=wulike1@huawei.com \
--cc=zhengjiezhen@h-partners.com \
--cc=zhoushuai28@huawei.com \
--cc=zhuyikai1@h-partners.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox