From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF4DBDF6C for ; Fri, 13 Mar 2026 08:50:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773391840; cv=none; b=WUCLyTitulQC7bGw0YV/Jd61ST7AZf9BvwcH38Gh53e6YQFYamEQ9KQvDK8tLMN5xwyTqvWXnjBgwxEQrqgA0Z/YqSiZHFeKQ/fdgaZ+Icr2+YXXSXkLkXAJMbAq3tkgfNJ1x4Ltnw1XqZ7pgvh0MZwvWpcTmXpVvvU51YMpXoA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773391840; c=relaxed/simple; bh=HngBp9zwUVTOc8cWhCRSHEddVxXjIezmA8vRWVUUUEk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uek/Tb3hGC3Z4jiWcLSOJ+YOfEM4k7J2nTYzVxDUnJ7qJDHGUJaHya6YbNPgQeCg7Bfk2Ax8kt50qhtuWiQLnnuiSjBNJzfQk6RXX2aSyRPM0y7f/ORgApdkUSgtXiGUC2VCB/OtagjW+PtVjMp5pGNg74XEZ39dmEFUm7ccl4k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=eDr52meg; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="eDr52meg" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 0DB1C4E4266E; Fri, 13 Mar 2026 08:50:36 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id CC9D260027; Fri, 13 Mar 2026 08:50:35 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id F043710369044; Fri, 13 Mar 2026 09:50:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1773391834; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=CRbMmZcTVgqE5UCl76Xsr6hd1uo+lW/4EJBhIeZPwB0=; b=eDr52megjJQxHtqmYRUkWlQDxRI8Iq4S2DcmFHREyTcxhqsnDLyk/xgun0DLxwbZlX/BoQ WaZ42lZj4IClnTP0o4xR3KazLfMOMXVi0TULKwzp0+9vTCf+vl4AvL60Qure6XMqlmLgiI 7IvbcXUG2DiafOVIa/KRDQ8Tua2n5lOyaddZ+I9zSQcmoud/zIHTVTvM0H2hTvf9huf7Et 7JWbTTn8nPi5dbeEzApTxjJ176YbcT9bbFzqE/Czx2ImaTai0xGnhuVo9qY3quOAnXxbxJ ow1R55q8/7akQ5uJViHyNxx1sVYF551H49OvGTEjnwofTxsd3jzGnIa9rJ8CnQ== Message-ID: <439753dc-496d-4e03-8480-ea409fb3d4bd@bootlin.com> Date: Fri, 13 Mar 2026 09:50:26 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v01 5/7] hinic3: Add MTU size validation To: Fan Gong , Zhu Yikai , netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Andrew Lunn , Ioana Ciornei Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, luosifu , Xin Guo , Zhou Shuai , Wu Like , Shi Jing , Zheng Jiezhen References: <53eb2c11ed4ccd93787352ef48ca56d6d51a150a.1773387649.git.zhuyikai1@h-partners.com> From: Maxime Chevallier Content-Language: en-US In-Reply-To: <53eb2c11ed4ccd93787352ef48ca56d6d51a150a.1773387649.git.zhuyikai1@h-partners.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi, On 13/03/2026 08:54, Fan Gong wrote: > Check whether the MTU size is within a reasonable range. I don't get why this is needed when we have netdev->min_mtu and netdev->max_mtu already to sanitize these parameters. Is this patch needed, and if so can you explain why the netdev->min/max_mtu parameters aren't enough ? Maxime