From: Daniel Borkmann <daniel@iogearbox.net>
To: Josef Bacik <josef@toxicpanda.com>,
rostedt@goodmis.org, mingo@redhat.com, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ast@kernel.org, kernel-team@fb.com, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v8 0/5] Add the ability to do BPF directed error injection
Date: Fri, 8 Dec 2017 16:35:44 +0100 [thread overview]
Message-ID: <439bccca-53e8-408e-972c-7f1b25ba0da6@iogearbox.net> (raw)
In-Reply-To: <1512576737-9417-1-git-send-email-josef@toxicpanda.com>
On 12/06/2017 05:12 PM, Josef Bacik wrote:
> Jon noticed that I had a typo in my _ASM_KPROBE_ERROR_INJECT macro. I went to
> figure out why the compiler didn't catch it and it's because it was not used
> anywhere. I had copied it from the trace blacklist code without understanding
> where it was used as cscope didn't find the original macro I was looking for, so
> I assumed it was some voodoo and left it in place. Turns out cscope failed me
> and I didn't need the macro at all, the trace blacklist thing I was looking at
> was for marking assembly functions as blacklisted and I have no intention of
> marking assembly functions as error injectable at the moment.
>
> v7->v8:
> - removed the _ASM_KPROBE_ERROR_INJECT since it was not needed.
The series doesn't apply cleanly to the bpf-next tree, so one last respin with
a rebase would unfortunately still be required, thanks!
next prev parent reply other threads:[~2017-12-08 15:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 16:12 [PATCH v8 0/5] Add the ability to do BPF directed error injection Josef Bacik
2017-12-06 16:12 ` [PATCH v8 1/5] add infrastructure for tagging functions as error injectable Josef Bacik
2017-12-06 16:12 ` [PATCH v8 2/5] btrfs: make open_ctree " Josef Bacik
2017-12-06 16:12 ` [PATCH v8 3/5] bpf: add a bpf_override_function helper Josef Bacik
2017-12-06 16:12 ` [PATCH v8 4/5] samples/bpf: add a test for bpf_override_return Josef Bacik
2017-12-06 16:12 ` [PATCH v8 5/5] btrfs: allow us to inject errors at io_ctl_init Josef Bacik
2017-12-08 15:35 ` Daniel Borkmann [this message]
2017-12-08 20:24 ` [PATCH v8 0/5] Add the ability to do BPF directed error injection Josef Bacik
2017-12-08 23:25 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=439bccca-53e8-408e-972c-7f1b25ba0da6@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox