* Re: [PATCH] netlink oops fix due to incorrect error code [not found] <43C27662.2030400@openvz.org> @ 2006-01-09 23:50 ` Patrick McHardy 2006-01-09 23:54 ` David S. Miller 0 siblings, 1 reply; 2+ messages in thread From: Patrick McHardy @ 2006-01-09 23:50 UTC (permalink / raw) To: Kirill Korotaev, David S. Miller Cc: Linus Torvalds, Andrew Morton, linux-kernel, Dmitry Mishin, Stanislav Protassov, Kernel Netdev Mailing List Kirill Korotaev wrote: > Fixed oops after failed netlink socket creation. > Wrong parathenses in if() statement caused err to be 1, > instead of negative value. > Trivial fix, not trivial to find though. > > Signed-Off-By: Dmitry Mishin <dim@sw.ru> > Signed-Off-By: Kirill Korotaev <dev@openvz.org> Good catch. Dave, please apply. > > ------------------------------------------------------------------------ > > --- ./net/netlink/af_netlink.c.nlfix 2006-01-06 18:37:28.000000000 +0300 > +++ ./net/netlink/af_netlink.c 2006-01-09 16:40:49.000000000 +0300 > @@ -416,7 +416,7 @@ static int netlink_create(struct socket > groups = nl_table[protocol].groups; > netlink_unlock_table(); > > - if ((err = __netlink_create(sock, protocol) < 0)) > + if ((err = __netlink_create(sock, protocol)) < 0) > goto out_module; > > nlk = nlk_sk(sock->sk); > ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] netlink oops fix due to incorrect error code 2006-01-09 23:50 ` [PATCH] netlink oops fix due to incorrect error code Patrick McHardy @ 2006-01-09 23:54 ` David S. Miller 0 siblings, 0 replies; 2+ messages in thread From: David S. Miller @ 2006-01-09 23:54 UTC (permalink / raw) To: kaber; +Cc: dev, torvalds, akpm, linux-kernel, dim, st, netdev From: Patrick McHardy <kaber@trash.net> Date: Tue, 10 Jan 2006 00:50:52 +0100 > Kirill Korotaev wrote: > > Fixed oops after failed netlink socket creation. > > Wrong parathenses in if() statement caused err to be 1, > > instead of negative value. > > Trivial fix, not trivial to find though. > > > > Signed-Off-By: Dmitry Mishin <dim@sw.ru> > > Signed-Off-By: Kirill Korotaev <dev@openvz.org> > > Good catch. Dave, please apply. Already in Linus's tree, he applied it directly :-) ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-01-09 23:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <43C27662.2030400@openvz.org>
2006-01-09 23:50 ` [PATCH] netlink oops fix due to incorrect error code Patrick McHardy
2006-01-09 23:54 ` David S. Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).