netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bill Davidsen <davidsen@tmr.com>
To: gcoady@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Patch] 2.4.32 - Neighbour Cache (ARP) State machine bug Fixed
Date: Fri, 10 Feb 2006 15:35:34 -0500	[thread overview]
Message-ID: <43ECF916.9080001@tmr.com> (raw)
In-Reply-To: <4skiu150r13a2a78i68bg28cvdb67a8qjb@4ax.com>

Grant Coady wrote:
> On Tue, 7 Feb 2006 17:50:03 -0800, Pradeep Vincent <pradeep.vincent@gmail.com> wrote:
> 
> 
>>One more attempt. Attaching the diff file as well.
>>
>>Signed off by: Pradeep Vincent <pradeep.vincent@gmail.com>
>>
>>--- old/net/core/neighbour.c    Wed Nov  9 16:48:10 2005
>>+++ new/net/core/neighbour.c    Tue Feb  7 17:38:26 2006
>>@@ -14,6 +14,7 @@
>> *     Vitaly E. Lavrov        releasing NULL neighbor in neigh_add.
>> *     Harald Welte            Add neighbour cache statistics like rtstat
>> *     Harald Welte            port neighbour cache rework from 2.6.9-rcX
>>+ *     Pradeep Vincent         fix neighbour cache state machine
>> */
>>
>>#include <linux/config.h>
>>@@ -705,6 +706,13 @@
>>                       neigh_release(n);
>>                       continue;
>>               }
>>+               /* Move to NUD_STALE state */
>>+               if (n->nud_state&NUD_REACHABLE &&
>>+                   now - n->confirmed > n->parms->reachable_time) {
> 
> 
> Hmm, you're suffering tab -> space conversion syndrome :(
> 
> Grant.

The attachment has tabs here, don't know what you're seeing.

-- 
bill davidsen <davidsen@tmr.com>
   CTO TMR Associates, Inc
   Doing interesting things with small computers since 1979

  reply	other threads:[~2006-02-10 20:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <9fda5f510511281257o364acb3gd634f8e412cd7301@mail.gmail.com>
2005-11-28 21:40 ` [Patch] 2.4.32 - Neighbour Cache (ARP) State machine bug Fixed Roberto Nibali
2006-02-04  2:06 ` Fwd: " Pradeep Vincent
2006-02-04  2:18   ` David S. Miller
2006-02-07  7:57     ` Pradeep Vincent
2006-02-07 21:53       ` Willy Tarreau
2006-02-08  1:50         ` Pradeep Vincent
2006-02-08  2:13           ` Grant Coady
2006-02-10 20:35             ` Bill Davidsen [this message]
2005-11-29 20:42 Pradeep Vincent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43ECF916.9080001@tmr.com \
    --to=davidsen@tmr.com \
    --cc=gcoady@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).