From: Patrick McHardy <kaber@trash.net>
To: Michael Richardson <mcr@sandelman.ottawa.on.ca>
Cc: netdev@vger.kernel.org, netfilter-devel@lists.netfilter.org,
shemminger@osdl.org
Subject: Re: [PATCH] iproute2 -- add fwmarkmask
Date: Fri, 24 Feb 2006 05:59:33 +0100 [thread overview]
Message-ID: <43FE92B5.4000606@trash.net> (raw)
In-Reply-To: <18992.1140723572@sandelman.ottawa.on.ca>
Michael Richardson wrote:
>
>
>>>>>>>"Patrick" == Patrick McHardy <kaber@trash.net> writes:
>
> Patrick> The normal way to display masks is with a "/". Also I think
> Patrick> it shouldn't display the default mask to avoid breaking
> Patrick> scripts that parse the output.
>
> I generally dislike the /VALUE, since I expect /PREFIX-LEN.
> I agree that it shouldn't show if it is default.
>
> Patrick> ip should be able to parse its own output, and it would
> Patrick> also look nicer if I could just say "fwmark
> Patrick> 0x1/32". fwmarkmask is really an incredible ugly expression
> Patrick> :)
>
> Sure. Is that a 32-bit long mask (0xfffffff), or is it a 0x00000020?
> fwmark is not an address.
>
> Or would you like /32 to be a prefix-based mask, and &value and/or
> fwmarkmask to be a value?
That was not the greatest example :) I think it should be a bitmask.
prev parent reply other threads:[~2006-02-24 4:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-20 16:27 [PATCH] iproute2 -- add fwmarkmask Michael Richardson
2006-02-20 17:03 ` Patrick McHardy
2006-02-23 19:39 ` Michael Richardson
2006-02-24 4:59 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43FE92B5.4000606@trash.net \
--to=kaber@trash.net \
--cc=mcr@sandelman.ottawa.on.ca \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).