From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Branden <scott.branden@broadcom.com>
Subject: Re: [PATCH] ethtool: Add ETHTOOL_RESET support via --reset command
Date: Mon, 4 Dec 2017 12:16:09 -0800
Message-ID: <43ab59b7-6670-23a5-b753-404e1337b33b@broadcom.com>
References: <1512069844-15664-1-git-send-email-scott.branden@broadcom.com>
 <d240f7d8-9655-df14-2c85-d8aa8db80319@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
        Steve Lin <steven.lin1@broadcom.com>,
        Michael Chan <michael.chan@broadcom.com>,
        netdev@vger.kernel.org
To: Gal Pressman <galp@mellanox.com>,
        "John W. Linville" <linville@tuxdriver.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-vk0-f65.google.com ([209.85.213.65]:32777 "EHLO
        mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751528AbdLDUQO (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 4 Dec 2017 15:16:14 -0500
Received: by mail-vk0-f65.google.com with SMTP id q189so10472968vke.0
        for <netdev@vger.kernel.org>; Mon, 04 Dec 2017 12:16:14 -0800 (PST)
In-Reply-To: <d240f7d8-9655-df14-2c85-d8aa8db80319@mellanox.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hi Gal,

I do not understand you're comment - questions inline


On 17-12-03 12:07 AM, Gal Pressman wrote:
> On 30-Nov-17 21:24, Scott Branden wrote:
>> Add ETHTOOL_RESET support via --reset command.
>>
>> ie.  ethtool --reset DEVNAME <flagname(s)>
>>
>> flagnames currently match the ETH_RESET_xxx names:
>> mgmt,irq,dma,filter,offload,mac,phy,ram,dedicated,all
>>
>> Alternatively, you can specific component bitfield directly using
>> ethtool --reset DEVNAME flags %x
>>
>> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
>> ---
>>   ethtool.8.in | 55 ++++++++++++++++++++++++++++++++++++++++++++-
>>   ethtool.c    | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 127 insertions(+), 1 deletion(-)
>>
>> diff --git a/ethtool.8.in b/ethtool.8.in
>> index 6ad3065..925cfe3 100644
>> --- a/ethtool.8.in
>> +++ b/ethtool.8.in
>> @@ -355,6 +355,20 @@ ethtool \- query or control network driver and hardware settings
>>   .B ethtool \-\-get\-phy\-tunable
>>   .I devname
>>   .RB [ downshift ]
>> +.HP
>> +.B ethtool \-\-reset
>> +.I devname
>> +.BN flags
>> +.B [mgmt]
>> +.B [irq]
>> +.B [dma]
>> +.B [filter]
>> +.B [offload]
>> +.B [mac]
>> +.B [phy]
>> +.B [ram]
>> +.B [dedicated]
>> +.B [all]
>>   .
> Nit:
> Usually, the brackets formatting is different than the keyword inside them.
Could you please explain what the formatting should be then?  Any of the 
options listed are possible components that can be selected.  At least 
one must be chosen.  Should the brackets be removed then?
>
> Gal