From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH v3 13/13] nvme-tcp: add NVMe over TCP host driver
Date: Mon, 26 Nov 2018 23:48:01 -0800
Message-ID: <43ad34a0-799d-5f78-a07f-e2c51f64a854@grimberg.me>
References: <20181122015615.15763-1-sagi@grimberg.me>
 <20181122015615.15763-14-sagi@grimberg.me> <20181122080224.GA26504@lst.de>
 <af432c70-1b3a-6c62-bb13-67bf7df1a43f@grimberg.me>
 <e4407485-843a-7968-c367-29d60baf8373@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
        netdev@vger.kernel.org, Keith Busch <keith.busch@intel.com>,
        "David S. Miller" <davem@davemloft.net>
To: Max Gurtovoy <maxg@mellanox.com>, Christoph Hellwig <hch@lst.de>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr1-f68.google.com ([209.85.221.68]:35206 "EHLO
        mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729085AbeK0SpI (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 27 Nov 2018 13:45:08 -0500
In-Reply-To: <e4407485-843a-7968-c367-29d60baf8373@mellanox.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>


>>> This looks odd.  It's not really the timeout handlers job to
>>> call nvme_end_request here.
>>
>> Well.. if we are not yet LIVE, we will not trigger error
>> recovery, which means nothing will complete this command so
>> something needs to do it...
>>
>> I think that we need it for rdma too..
> 
> 
> yes we do. and we've patches in our pipe.
> 
> I'm thinking on a wider change in the error/recovery flows but might 
> send it "as is" meanwhile.

I have it too in the pipe. Do you want to send it out or should I?