From: Heiner Kallweit <hkallweit1@gmail.com>
To: Realtek linux nic maintainers <nic_swsd@realtek.com>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [PATCH net-next v2] r8169: use the extended tally counter available from RTL8125
Date: Thu, 10 Oct 2024 12:50:22 +0200 [thread overview]
Message-ID: <43b100c5-9d53-46eb-bee0-940ab948722a@gmail.com> (raw)
The new hw stat fields partially duplicate existing fields, but with a
larger field size now. Use these new fields to reduce the risk of
overflows. In addition add support for relevant new fields which are
available from RTL8125 only.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
v2:
- added code for enabling the extended tally counter
- included relevant new fields
---
drivers/net/ethernet/realtek/r8169_main.c | 40 ++++++++++++++++++++++-
1 file changed, 39 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index 665105430..71339910b 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -1777,11 +1777,26 @@ static const char rtl8169_gstrings[][ETH_GSTRING_LEN] = {
"tx_underrun",
};
+static const char rtl8125_gstrings[][ETH_GSTRING_LEN] = {
+ "tx_bytes",
+ "rx_bytes",
+ "tx_pause_on",
+ "tx_pause_off",
+ "rx_pause_on",
+ "rx_pause_off",
+};
+
static int rtl8169_get_sset_count(struct net_device *dev, int sset)
{
switch (sset) {
case ETH_SS_STATS:
- return ARRAY_SIZE(rtl8169_gstrings);
+ struct rtl8169_private *tp = netdev_priv(dev);
+
+ if (rtl_is_8125(tp))
+ return ARRAY_SIZE(rtl8169_gstrings) +
+ ARRAY_SIZE(rtl8125_gstrings);
+ else
+ return ARRAY_SIZE(rtl8169_gstrings);
default:
return -EOPNOTSUPP;
}
@@ -1873,13 +1888,33 @@ static void rtl8169_get_ethtool_stats(struct net_device *dev,
data[10] = le32_to_cpu(counters->rx_multicast);
data[11] = le16_to_cpu(counters->tx_aborted);
data[12] = le16_to_cpu(counters->tx_underrun);
+
+ if (rtl_is_8125(tp)) {
+ data[5] = le32_to_cpu(counters->align_errors32);
+ data[10] = le64_to_cpu(counters->rx_multicast64);
+ data[11] = le32_to_cpu(counters->tx_aborted32);
+ data[12] = le32_to_cpu(counters->tx_underrun32);
+
+ data[13] = le64_to_cpu(counters->tx_octets);
+ data[14] = le64_to_cpu(counters->rx_octets);
+ data[15] = le32_to_cpu(counters->tx_pause_on);
+ data[16] = le32_to_cpu(counters->tx_pause_off);
+ data[17] = le32_to_cpu(counters->rx_pause_on);
+ data[18] = le32_to_cpu(counters->rx_pause_off);
+ }
}
static void rtl8169_get_strings(struct net_device *dev, u32 stringset, u8 *data)
{
switch(stringset) {
case ETH_SS_STATS:
+ struct rtl8169_private *tp = netdev_priv(dev);
+
memcpy(data, rtl8169_gstrings, sizeof(rtl8169_gstrings));
+ if (rtl_is_8125(tp)) {
+ data += sizeof(rtl8169_gstrings);
+ memcpy(data, rtl8125_gstrings, sizeof(rtl8125_gstrings));
+ }
break;
}
}
@@ -3894,6 +3929,9 @@ static void rtl_hw_start_8125(struct rtl8169_private *tp)
break;
}
+ /* enable extended tally counter */
+ r8168_mac_ocp_modify(tp, 0xea84, 0, BIT(1) | BIT(0));
+
rtl_hw_config(tp);
}
--
2.47.0
next reply other threads:[~2024-10-10 10:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 10:50 Heiner Kallweit [this message]
2024-10-10 20:08 ` [PATCH net-next v2] r8169: use the extended tally counter available from RTL8125 Heiner Kallweit
2024-10-11 9:55 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43b100c5-9d53-46eb-bee0-940ab948722a@gmail.com \
--to=hkallweit1@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).