From: Julius Volz <julius.volz@gmail.com>
To: Simon Horman <horms@verge.net.au>
Cc: David Miller <davem@davemloft.net>,
eric.dumazet@gmail.com, lvs-devel@vger.kernel.org,
netdev@vger.kernel.org, robert.gallagher@heanet.ie
Subject: Re: [PATCH] IPVS: Add handling of incoming ICMPV6_PKT_TOOBIG messages
Date: Mon, 27 Jul 2009 12:19:03 +0200 [thread overview]
Message-ID: <43ca39800907270319r4fd42236v21ade59dc56b02da@mail.gmail.com> (raw)
In-Reply-To: <20090727023754.GC723@verge.net.au>
On Mon, Jul 27, 2009 at 4:37 AM, Simon Horman<horms@verge.net.au> wrote:
> On Sun, Jul 26, 2009 at 07:19:05PM -0700, David Miller wrote:
>> From: Eric Dumazet <eric.dumazet@gmail.com>
>> Date: Fri, 24 Jul 2009 06:25:25 +0200
>>
>> > I see no reference to ICMPV6_PKT_TOOBIG in this patch, so ChangeLog
>> > might be misleading or uncomplete, since other ICMPV6 message types
>> > (ICMPV6_DEST_UNREACH/ICMPV6_TIME_EXCEED) will also be forwarded/handled
>> > ?
>>
>> Agreed, this commit message could use a tidy. What the patch actually is
>> doing is adding the handling of ipv6 icmp messages at all.
>>
>> Simon could you clarify the commit message a bit and resubmit?
>
> Will do.
Oops, yes. For some weird reason, only the specific problem that
caused the patch was in my head when writing that commit message. Feel
free to edit it to include ICMPv6 handling for in-out packets in
general.
Julius
prev parent reply other threads:[~2009-07-27 10:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 13:22 [PATCH] IPVS: Add handling of incoming ICMPV6_PKT_TOOBIG messages Julius Volz
2009-06-28 15:43 ` Simon Horman
2009-07-02 14:43 ` Julius Volz
2009-07-10 9:56 ` Simon Horman
2009-07-24 2:47 ` Simon Horman
2009-07-24 4:25 ` Eric Dumazet
2009-07-27 2:19 ` David Miller
2009-07-27 2:37 ` Simon Horman
2009-07-27 10:19 ` Julius Volz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43ca39800907270319r4fd42236v21ade59dc56b02da@mail.gmail.com \
--to=julius.volz@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=horms@verge.net.au \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robert.gallagher@heanet.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).