From: David Ahern <dsahern@gmail.com>
To: pruddy@vyatta.att-mail.com, Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: netdev <netdev@vger.kernel.org>, "Jiří Pírko" <jiri@resnulli.us>,
"Stephen Hemminger" <stephen@networkplumber.org>,
"Nikolay Aleksandrov" <nikolay@cumulusnetworks.com>
Subject: Re: [PATCH net-next v3 1/2] netlink: ipv4 igmp join notifications
Date: Wed, 19 Sep 2018 21:47:04 -0700 [thread overview]
Message-ID: <43d8f45e-64f6-17a6-d07f-99c33a515347@gmail.com> (raw)
In-Reply-To: <a7629503af0aa345d65b1651586f906dc7259484.camel@vyatta.att-mail.com>
On 9/18/18 6:12 AM, Patrick Ruddy wrote:
>
> I've hit a small snag with adding the new groups. The number of defined
> groups currently sits at 31 so I can only add one before hitting the
I believe you have no more available. RTNLGRP_* has been defined from 0
(RTNLGRP_NONE) to 31 (RTNLGRP_IPV6_MROUTE_R) which covers the u32 range.
> limit defined by the 32 bit groups bitmask in socakddr_nl. I can use 1
> group for both v4 and v6 notifications which seems like the sensible
> options since the AF is carried separately, but it breaks the precedent
> where there are separate IPV4 and IPV6 groups for IFADDR.
>
> I have the combined group patches ready and can share them if that's
> the preference.
>
> Has there been any previous discussion about extending the number of
> availabel groups?
>
I have not tried it, but from a prior code review I believe you have you
use setsockopt to add groups > 31.
next prev parent reply other threads:[~2018-09-20 10:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 9:35 [PATCH net-next 0/2] netlink: multicast join notifications Patrick Ruddy
2018-08-30 9:35 ` [PATCH net-next 1/2] netlink: ipv4 IGMP " Patrick Ruddy
2018-08-30 16:44 ` Patrick Ruddy
2018-08-31 4:23 ` kbuild test robot
2018-08-31 4:52 ` kbuild test robot
2018-08-31 11:20 ` [PATCH net-next v2 1/2] netlink: ipv4 igmp " Patrick Ruddy
2018-08-31 11:20 ` [PATCH net-next v2 2/2] netlink: ipv6 MLD " Patrick Ruddy
2018-08-31 16:29 ` [PATCH net-next v2 1/2] netlink: ipv4 igmp " Roopa Prabhu
2018-09-02 11:18 ` Patrick Ruddy
2018-09-03 23:12 ` Roopa Prabhu
2018-09-04 7:54 ` Patrick Ruddy
2018-09-04 16:36 ` Patrick Ruddy
2018-09-06 9:10 ` [PATCH net-next v3 " Patrick Ruddy
2018-09-06 9:10 ` [PATCH net-next v3 2/2] netlink: ipv6 MLD " Patrick Ruddy
2018-09-07 3:40 ` [PATCH net-next v3 1/2] netlink: ipv4 igmp " Roopa Prabhu
2018-09-13 17:03 ` Roopa Prabhu
2018-09-13 17:49 ` Patrick Ruddy
2018-09-18 13:12 ` Patrick Ruddy
2018-09-20 4:47 ` David Ahern [this message]
2018-09-25 9:34 ` Patrick Ruddy
2018-09-26 17:23 ` Roopa Prabhu
2018-10-01 15:38 ` Roopa Prabhu
2018-08-30 9:35 ` [PATCH net-next 2/2] netlink: ipv6 MLD " Patrick Ruddy
2018-08-31 5:35 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43d8f45e-64f6-17a6-d07f-99c33a515347@gmail.com \
--to=dsahern@gmail.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=pruddy@vyatta.att-mail.com \
--cc=roopa@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).