From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net-next v3 1/2] netlink: ipv4 igmp join notifications
Date: Wed, 19 Sep 2018 21:47:04 -0700
Message-ID: <43d8f45e-64f6-17a6-d07f-99c33a515347@gmail.com>
References: <20180830093545.29465-2-pruddy@vyatta.att-mail.com>
 <20180906091056.21109-1-pruddy@vyatta.att-mail.com>
 <CAJieiUgopvmN5VVntPwffP5YmVZGFsWJvafSSXj83DVBVA61uQ@mail.gmail.com>
 <CAJieiUg03p6MNkZCdO65p4uQuOCVTN4mDr0htQNeYumrpDQMeA@mail.gmail.com>
 <a7629503af0aa345d65b1651586f906dc7259484.camel@vyatta.att-mail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev <netdev@vger.kernel.org>,
        =?UTF-8?B?SmnFmcOtIFDDrXJrbw==?= <jiri@resnulli.us>,
        Stephen Hemminger <stephen@networkplumber.org>,
        Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: pruddy@vyatta.att-mail.com,
        Roopa Prabhu <roopa@cumulusnetworks.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl1-f195.google.com ([209.85.214.195]:45333 "EHLO
        mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726902AbeITK1n (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 20 Sep 2018 06:27:43 -0400
Received: by mail-pl1-f195.google.com with SMTP id j8-v6so3681051pll.12
        for <netdev@vger.kernel.org>; Wed, 19 Sep 2018 21:46:16 -0700 (PDT)
In-Reply-To: <a7629503af0aa345d65b1651586f906dc7259484.camel@vyatta.att-mail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 9/18/18 6:12 AM, Patrick Ruddy wrote:
> 
> I've hit a small snag with adding the new groups. The number of defined
> groups currently sits at 31 so I can only add one before hitting the

I believe you have no more available. RTNLGRP_* has been defined from 0
(RTNLGRP_NONE) to 31 (RTNLGRP_IPV6_MROUTE_R) which covers the u32 range.

> limit defined by the 32 bit groups bitmask in socakddr_nl. I can use 1
> group for both v4 and v6 notifications which seems like the sensible
> options since the AF is carried separately, but it breaks the precedent
> where there are separate IPV4 and IPV6 groups for IFADDR.
> 
> I have the combined group patches ready and can share them if that's
> the preference.
> 
> Has there been any previous discussion about extending the number of
> availabel groups?
> 

I have not tried it, but from a prior code review I believe you have you
use setsockopt to add groups > 31.