From: "Luis R. Rodriguez" <mcgrof@gmail.com>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: netdev@oss.sgi.com, jgarzik <jgarzik@pobox.com>,
prism54-devel@prism54.org
Subject: Re: [PATCH] prism54: fix printk format warnings
Date: Sun, 17 Apr 2005 18:24:53 -0400 [thread overview]
Message-ID: <43e72e8905041715247c8765f0@mail.gmail.com> (raw)
In-Reply-To: <20050301212137.57f9532f.rddunlap@osdl.org>
Thanks Randy. This is already in prism54 svn tree. Feel free to apply Jeff.
Luis
On 3/2/05, Randy.Dunlap <rddunlap@osdl.org> wrote:
>
> prism54 build shows some printk format complaints:
> (sparc64 build warning)
>
> drivers/net/wireless/prism54/isl_38xx.c:131: warning: long int format, different type arg (arg 3)
> drivers/net/wireless/prism54/isl_38xx.c:151: warning: long int format, different type arg (arg 3)
>
> cross-compile results:
> https://www.osdl.org/plm-cgi/plm?module=patch_info&patch_id=4240
>
> Signed-off-by: Randy Dunlap <rddunlap@osdl.org>
>
> diffstat:=
> drivers/net/wireless/prism54/isl_38xx.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff -Naurp ./drivers/net/wireless/prism54/isl_38xx.c~prism_printk ./drivers/net/wireless/prism54/isl_38xx.c
> --- ./drivers/net/wireless/prism54/isl_38xx.c~prism_printk 2004-12-24 13:34:45.000000000 -0800
> +++ ./drivers/net/wireless/prism54/isl_38xx.c 2005-03-01 20:15:00.189995120 -0800
> @@ -125,11 +125,11 @@ isl38xx_trigger_device(int asleep, void
> #if VERBOSE > SHOW_ERROR_MESSAGES
> do_gettimeofday(¤t_time);
> DEBUG(SHOW_TRACING, "%08li.%08li Device wakeup triggered\n",
> - current_time.tv_sec, current_time.tv_usec);
> + current_time.tv_sec, (long)current_time.tv_usec);
> #endif
>
> DEBUG(SHOW_TRACING, "%08li.%08li Device register read %08x\n",
> - current_time.tv_sec, current_time.tv_usec,
> + current_time.tv_sec, (long)current_time.tv_usec,
> readl(device_base + ISL38XX_CTRL_STAT_REG));
> udelay(ISL38XX_WRITEIO_DELAY);
>
> @@ -139,7 +139,7 @@ isl38xx_trigger_device(int asleep, void
> do_gettimeofday(¤t_time);
> DEBUG(SHOW_TRACING,
> "%08li.%08li Device register abadface\n",
> - current_time.tv_sec, current_time.tv_usec);
> + current_time.tv_sec, (long)current_time.tv_usec);
> #endif
> /* read the Device Status Register until Sleepmode bit is set */
> while (reg = readl(device_base + ISL38XX_CTRL_STAT_REG),
> @@ -150,7 +150,7 @@ isl38xx_trigger_device(int asleep, void
>
> DEBUG(SHOW_TRACING,
> "%08li.%08li Device register read %08x\n",
> - current_time.tv_sec, current_time.tv_usec,
> + current_time.tv_sec, (long)current_time.tv_usec,
> readl(device_base + ISL38XX_CTRL_STAT_REG));
> udelay(ISL38XX_WRITEIO_DELAY);
>
> @@ -158,7 +158,7 @@ isl38xx_trigger_device(int asleep, void
> do_gettimeofday(¤t_time);
> DEBUG(SHOW_TRACING,
> "%08li.%08li Device asleep counter %i\n",
> - current_time.tv_sec, current_time.tv_usec,
> + current_time.tv_sec, (long)current_time.tv_usec,
> counter);
> #endif
> }
> @@ -174,7 +174,7 @@ isl38xx_trigger_device(int asleep, void
> #if VERBOSE > SHOW_ERROR_MESSAGES
> do_gettimeofday(¤t_time);
> DEBUG(SHOW_TRACING, "%08li.%08li Device register read %08x\n",
> - current_time.tv_sec, current_time.tv_usec, reg);
> + current_time.tv_sec, (long)current_time.tv_usec, reg);
> #endif
> } else {
> /* device is (still) awake */
>
> ---
>
prev parent reply other threads:[~2005-04-17 22:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-02 5:21 [PATCH] prism54: fix printk format warnings Randy.Dunlap
2005-04-17 22:24 ` Luis R. Rodriguez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43e72e8905041715247c8765f0@mail.gmail.com \
--to=mcgrof@gmail.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=prism54-devel@prism54.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).