From: "Luis R. Rodriguez" <mcgrof@gmail.com>
To: Olaf Hering <olh@suse.de>
Cc: Jeff Garzik <jgarzik@pobox.com>,
netdev@oss.sgi.com, prism54-private@prism54.org
Subject: Re: [PATCH] uninitialized variable in prism54 isl38xx_trigger_device
Date: Thu, 16 Jun 2005 19:52:04 -0400 [thread overview]
Message-ID: <43e72e8905061616527858ebd6@mail.gmail.com> (raw)
In-Reply-To: <20050525231651.GA21816@suse.de>
Sure, why not. This has been applied to prism54 svn tree.
On 5/25/05, Olaf Hering <olh@suse.de> wrote:
>
> drivers/net/wireless/prism54/isl_38xx.c:131: warning: 'current_time.tv_sec' is used uninitialized in this function
> drivers/net/wireless/prism54/isl_38xx.c:131: warning: 'current_time.tv_usec' is used uninitialized in this function
>
> Signed-off-by: Olaf Hering <olh@suse.de>
> Index: linux-2.6.12-rc5-olh/drivers/net/wireless/prism54/isl_38xx.c
> ===================================================================
> --- linux-2.6.12-rc5-olh.orig/drivers/net/wireless/prism54/isl_38xx.c
> +++ linux-2.6.12-rc5-olh/drivers/net/wireless/prism54/isl_38xx.c
> @@ -112,10 +112,10 @@ isl38xx_handle_wakeup(isl38xx_control_bl
> void
> isl38xx_trigger_device(int asleep, void __iomem *device_base)
> {
> - struct timeval current_time;
> u32 reg, counter = 0;
>
> #if VERBOSE > SHOW_ERROR_MESSAGES
> + struct timeval current_time;
> DEBUG(SHOW_FUNCTION_CALLS, "isl38xx trigger device\n");
> #endif
>
> @@ -126,11 +126,11 @@ isl38xx_trigger_device(int asleep, void
> do_gettimeofday(¤t_time);
> DEBUG(SHOW_TRACING, "%08li.%08li Device wakeup triggered\n",
> current_time.tv_sec, (long)current_time.tv_usec);
> -#endif
>
> DEBUG(SHOW_TRACING, "%08li.%08li Device register read %08x\n",
> current_time.tv_sec, (long)current_time.tv_usec,
> readl(device_base + ISL38XX_CTRL_STAT_REG));
> +#endif
> udelay(ISL38XX_WRITEIO_DELAY);
>
> reg = readl(device_base + ISL38XX_INT_IDENT_REG);
> @@ -148,10 +148,12 @@ isl38xx_trigger_device(int asleep, void
> counter++;
> }
>
> +#if VERBOSE > SHOW_ERROR_MESSAGES
> DEBUG(SHOW_TRACING,
> "%08li.%08li Device register read %08x\n",
> current_time.tv_sec, (long)current_time.tv_usec,
> readl(device_base + ISL38XX_CTRL_STAT_REG));
> +#endif
> udelay(ISL38XX_WRITEIO_DELAY);
>
> #if VERBOSE > SHOW_ERROR_MESSAGES
>
prev parent reply other threads:[~2005-06-16 23:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-25 23:16 [PATCH] uninitialized variable in prism54 isl38xx_trigger_device Olaf Hering
2005-06-16 23:52 ` Luis R. Rodriguez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43e72e8905061616527858ebd6@mail.gmail.com \
--to=mcgrof@gmail.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=olh@suse.de \
--cc=prism54-private@prism54.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).