netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Santiago Leon <santil@us.ibm.com>
To: anton@samba.org, linuxppc64-dev@ozlabs.org,
	michael@ellerman.id.au, jgarzik@pobox.com,
	netdev@vger.kernel.org
Subject: [PATCH] powerpc: ibmveth: Harden driver initilisation for kexec
Date: Thu, 02 Mar 2006 13:40:18 -0600	[thread overview]
Message-ID: <44074A22.8060705@us.ibm.com> (raw)
In-Reply-To: <20060131042903.GF28896@krispykreme>

From: Michael Ellerman <michael@ellerman.id.au>

After a kexec the veth driver will fail when trying to register with the
Hypervisor because the previous kernel has not unregistered.

So if the registration fails, we unregister and then try again.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Acked-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Santiago Leon <santil@us.ibm.com>
---

  drivers/net/ibmveth.c |   32 ++++++++++++++++++++++++++------
  1 files changed, 26 insertions(+), 6 deletions(-)

Looks good to me, and has been around for a couple of months.

Index: kexec/drivers/net/ibmveth.c
===================================================================
--- kexec.orig/drivers/net/ibmveth.c
+++ kexec/drivers/net/ibmveth.c
@@ -436,6 +436,31 @@ static void ibmveth_cleanup(struct ibmve
  		ibmveth_free_buffer_pool(adapter, &adapter->rx_buff_pool[i]);
  }

+static int ibmveth_register_logical_lan(struct ibmveth_adapter *adapter,
+		union ibmveth_buf_desc rxq_desc, u64 mac_address)
+{
+	int rc, try_again = 1;
+
+	/* After a kexec the adapter will still be open, so our attempt to
+	 * open it will fail. So if we get a failure we free the adapter and
+	 * try again, but only once. */
+retry:
+	rc = h_register_logical_lan(adapter->vdev->unit_address,
+			adapter->buffer_list_dma, rxq_desc.desc,
+			adapter->filter_list_dma, mac_address);
+
+	if (rc != H_Success && try_again) {
+		do {
+			rc = h_free_logical_lan(adapter->vdev->unit_address);
+		} while (H_isLongBusy(rc) || (rc == H_Busy));
+
+		try_again = 0;
+		goto retry;
+	}
+
+	return rc;
+}
+
  static int ibmveth_open(struct net_device *netdev)
  {
  	struct ibmveth_adapter *adapter = netdev->priv;
@@ -504,12 +529,7 @@ static int ibmveth_open(struct net_devic
  	ibmveth_debug_printk("filter list @ 0x%p\n", adapter->filter_list_addr);
  	ibmveth_debug_printk("receive q   @ 0x%p\n", 
adapter->rx_queue.queue_addr);

-
-	lpar_rc = h_register_logical_lan(adapter->vdev->unit_address,
-					 adapter->buffer_list_dma,
-					 rxq_desc.desc,
-					 adapter->filter_list_dma,
-					 mac_address);
+	lpar_rc = ibmveth_register_logical_lan(adapter, rxq_desc, mac_address);

  	if(lpar_rc != H_Success) {
  		ibmveth_error_printk("h_register_logical_lan failed with %ld\n", 
lpar_rc);

       reply	other threads:[~2006-03-02 19:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060131041055.5623C68A46@ozlabs.org>
     [not found] ` <20060131042903.GF28896@krispykreme>
2006-03-02 19:40   ` Santiago Leon [this message]
2006-03-03  0:22     ` [PATCH] powerpc: ibmveth: Harden driver initilisation for kexec Michael Ellerman
2006-03-03  0:34       ` Randy.Dunlap
2006-03-03  1:00         ` Paul Mackerras
2006-03-03  1:10         ` Michael Ellerman
2006-03-03  4:12           ` Randy.Dunlap
2006-03-03  1:04     ` Jeff Garzik
2006-03-03  2:11       ` Michael Ellerman
2006-03-27  1:11     ` Michael Ellerman
2006-04-26 10:37       ` Michael Ellerman
2006-04-28 19:51         ` Santiago Leon
2006-08-29 12:58           ` Michael Ellerman
2006-09-18  4:31 Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44074A22.8060705@us.ibm.com \
    --to=santil@us.ibm.com \
    --cc=anton@samba.org \
    --cc=jgarzik@pobox.com \
    --cc=linuxppc64-dev@ozlabs.org \
    --cc=michael@ellerman.id.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).