netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Santiago Leon <santil@us.ibm.com>
Cc: michael@ellerman.id.au, linuxppc64-dev@ozlabs.org,
	Paul Mackerras <paulus@samba.org>,
	anton@samba.org, netdev@vger.kernel.org
Subject: Re: [PATCH] powerpc: ibmveth: Harden driver initilisation for kexec
Date: Thu, 02 Mar 2006 20:04:39 -0500	[thread overview]
Message-ID: <44079627.6070100@pobox.com> (raw)
In-Reply-To: <44074A22.8060705@us.ibm.com>

Santiago Leon wrote:
> From: Michael Ellerman <michael@ellerman.id.au>
> 
> After a kexec the veth driver will fail when trying to register with the
> Hypervisor because the previous kernel has not unregistered.
> 
> So if the registration fails, we unregister and then try again.
> 
> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
> Acked-by: Anton Blanchard <anton@samba.org>
> Signed-off-by: Santiago Leon <santil@us.ibm.com>
> ---
> 
>  drivers/net/ibmveth.c |   32 ++++++++++++++++++++++++++------
>  1 files changed, 26 insertions(+), 6 deletions(-)
> 
> Looks good to me, and has been around for a couple of months.

This seems completely bonkers to me:

	are resources available?
	if no
		free resources
		try again

It makes resource checking pointless.

	Jeff

  parent reply	other threads:[~2006-03-03  1:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060131041055.5623C68A46@ozlabs.org>
     [not found] ` <20060131042903.GF28896@krispykreme>
2006-03-02 19:40   ` [PATCH] powerpc: ibmveth: Harden driver initilisation for kexec Santiago Leon
2006-03-03  0:22     ` Michael Ellerman
2006-03-03  0:34       ` Randy.Dunlap
2006-03-03  1:00         ` Paul Mackerras
2006-03-03  1:10         ` Michael Ellerman
2006-03-03  4:12           ` Randy.Dunlap
2006-03-03  1:04     ` Jeff Garzik [this message]
2006-03-03  2:11       ` Michael Ellerman
2006-03-27  1:11     ` Michael Ellerman
2006-04-26 10:37       ` Michael Ellerman
2006-04-28 19:51         ` Santiago Leon
2006-08-29 12:58           ` Michael Ellerman
2006-09-18  4:31 Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44079627.6070100@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=anton@samba.org \
    --cc=linuxppc64-dev@ozlabs.org \
    --cc=michael@ellerman.id.au \
    --cc=netdev@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=santil@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).