* [RFC: 2.6 patch] let NET_CLS_ACT no longer depend on EXPERIMENTAL
@ 2006-03-04 16:07 Adrian Bunk
2006-03-04 16:56 ` Patrick McHardy
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2006-03-04 16:07 UTC (permalink / raw)
To: netdev; +Cc: linux-kernel
This option should IMHO no longer depend on EXPERIMENTAL.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 12 Feb 2006
--- linux-2.6.16-rc2-mm1-full/net/sched/Kconfig.old 2006-02-12 02:21:30.000000000 +0100
+++ linux-2.6.16-rc2-mm1-full/net/sched/Kconfig 2006-02-12 02:21:58.000000000 +0100
@@ -434,7 +434,6 @@
config NET_CLS_ACT
bool "Actions"
- depends on EXPERIMENTAL
select NET_ESTIMATOR
---help---
Say Y here if you want to use traffic control actions. Actions
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC: 2.6 patch] let NET_CLS_ACT no longer depend on EXPERIMENTAL
2006-03-04 16:07 [RFC: 2.6 patch] let NET_CLS_ACT no longer depend on EXPERIMENTAL Adrian Bunk
@ 2006-03-04 16:56 ` Patrick McHardy
2006-03-04 18:52 ` jamal
0 siblings, 1 reply; 6+ messages in thread
From: Patrick McHardy @ 2006-03-04 16:56 UTC (permalink / raw)
To: Adrian Bunk; +Cc: netdev, linux-kernel
Adrian Bunk wrote:
> This option should IMHO no longer depend on EXPERIMENTAL.
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
> This patch was already sent on:
> - 12 Feb 2006
Yesterday I managed to crash my machine playing around with tc actions
within minutes. I haven't looked into it yet, but it seems it still
needs more testing.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC: 2.6 patch] let NET_CLS_ACT no longer depend on EXPERIMENTAL
2006-03-04 16:56 ` Patrick McHardy
@ 2006-03-04 18:52 ` jamal
2006-03-04 20:36 ` Patrick McHardy
2006-03-10 11:04 ` David S. Miller
0 siblings, 2 replies; 6+ messages in thread
From: jamal @ 2006-03-04 18:52 UTC (permalink / raw)
To: Patrick McHardy; +Cc: Adrian Bunk, netdev, linux-kernel
On Sat, 2006-04-03 at 17:56 +0100, Patrick McHardy wrote:
> Adrian Bunk wrote:
> > This option should IMHO no longer depend on EXPERIMENTAL.
> >
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> >
> > ---
> >
> > This patch was already sent on:
> > - 12 Feb 2006
>
> Yesterday I managed to crash my machine playing around with tc actions
> within minutes. I haven't looked into it yet, but it seems it still
> needs more testing.
Simple: Fix the bug and submit a patch. If you cant find the cause post
what you are doing.
What is the metric for going from experimental to non-experimental?
I surely hope it doesnt come to some irrational reasoning like
"Patrick found a bug"[1].
- It has been around since 2.6.7/8;
- I use it extensively on about 10 machines since (I am pretty sure a
lot more extensively than Patrick)
- I know people who use it extensively
- I am pretty sure there are people that i dont know who use it
extensively
So on Adrian's patch and above reasoning:
ACKed-by: Jamal Hadi Salim <hadi@cyberus.ca>
cheers,
jamal
[1]If you used half of that logic on netfilter it would still be
experimental or rather should be demoted to experimental.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC: 2.6 patch] let NET_CLS_ACT no longer depend on EXPERIMENTAL
2006-03-04 18:52 ` jamal
@ 2006-03-04 20:36 ` Patrick McHardy
2006-03-10 11:04 ` David S. Miller
1 sibling, 0 replies; 6+ messages in thread
From: Patrick McHardy @ 2006-03-04 20:36 UTC (permalink / raw)
To: hadi; +Cc: Adrian Bunk, netdev, linux-kernel
jamal wrote:
> On Sat, 2006-04-03 at 17:56 +0100, Patrick McHardy wrote:
>
>>Adrian Bunk wrote:
>>
>>>This option should IMHO no longer depend on EXPERIMENTAL.
>>>
>>
>>Yesterday I managed to crash my machine playing around with tc actions
>>within minutes. I haven't looked into it yet, but it seems it still
>>needs more testing.
>
>
> Simple: Fix the bug and submit a patch. If you cant find the cause post
> what you are doing.
I'll fix it.
> What is the metric for going from experimental to non-experimental?
> I surely hope it doesnt come to some irrational reasoning like
> "Patrick found a bug"[1].
I think a sane metric is "opinion of people who know the code". But
I don't care much, I don't think many people care whether something
is maked experimental or not.
> [1]If you used half of that logic on netfilter it would still be
> experimental or rather should be demoted to experimental.
I'll take that as a compliment :)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC: 2.6 patch] let NET_CLS_ACT no longer depend on EXPERIMENTAL
2006-03-04 18:52 ` jamal
2006-03-04 20:36 ` Patrick McHardy
@ 2006-03-10 11:04 ` David S. Miller
1 sibling, 0 replies; 6+ messages in thread
From: David S. Miller @ 2006-03-10 11:04 UTC (permalink / raw)
To: hadi; +Cc: kaber, bunk, netdev, linux-kernel
From: jamal <hadi@cyberus.ca>
Date: Sat, 04 Mar 2006 13:52:21 -0500
> So on Adrian's patch and above reasoning:
>
> ACKed-by: Jamal Hadi Salim <hadi@cyberus.ca>
Applied, thanks Adrian.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RFC: 2.6 patch] let NET_CLS_ACT no longer depend on EXPERIMENTAL
@ 2006-02-12 17:56 Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2006-02-12 17:56 UTC (permalink / raw)
To: netdev; +Cc: linux-kernel
This option should IMHO no longer depend on EXPERIMENTAL.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.16-rc2-mm1-full/net/sched/Kconfig.old 2006-02-12 02:21:30.000000000 +0100
+++ linux-2.6.16-rc2-mm1-full/net/sched/Kconfig 2006-02-12 02:21:58.000000000 +0100
@@ -434,7 +434,6 @@
config NET_CLS_ACT
bool "Actions"
- depends on EXPERIMENTAL
select NET_ESTIMATOR
---help---
Say Y here if you want to use traffic control actions. Actions
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-03-10 11:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-04 16:07 [RFC: 2.6 patch] let NET_CLS_ACT no longer depend on EXPERIMENTAL Adrian Bunk
2006-03-04 16:56 ` Patrick McHardy
2006-03-04 18:52 ` jamal
2006-03-04 20:36 ` Patrick McHardy
2006-03-10 11:04 ` David S. Miller
-- strict thread matches above, loose matches on Subject: below --
2006-02-12 17:56 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).