From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shailabh Nagar Subject: Re: [UPDATED PATCH] Re: Re: [Patch 7/7] Generic netlink interface (delay accounting) Date: Thu, 09 Mar 2006 11:06:43 -0500 Message-ID: <44105293.2010803@watson.ibm.com> References: <1141026996.5785.38.camel@elinux04.optonline.net> <1141029060.5785.77.camel@elinux04.optonline.net> <1141045194.5363.12.camel@localhost.localdomain> <4403608E.1050304@watson.ibm.com> <1141652556.5185.64.camel@localhost.localdomain> <440C6AAA.9030301@watson.ibm.com> <1141742282.5171.55.camel@localhost.localdomain> <440F52FF.30908@watson.ibm.com> <20060309143759.GA4653@in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: hadi@cyberus.ca, netdev , linux-kernel , lse-tech@lists.sourceforge.net Return-path: To: balbir@in.ibm.com In-Reply-To: <20060309143759.GA4653@in.ibm.com> Sender: lse-tech-admin@lists.sourceforge.net Errors-To: lse-tech-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: List-Id: netdev.vger.kernel.org Balbir Singh wrote: >Hello, Jamal, > >Please find the latest version of the patch for review. The genetlink >code has been updated as per your review comments. The changelog is provided >below > >1. Eliminated TASKSTATS_CMD_LISTEN and TASKSTATS_CMD_IGNORE >2. Provide generic functions called genlmsg_data() and genlmsg_len() > in linux/net/genetlink.h > > Balbir, it might be a good idea to split 2. out separately, since it has generic value beyond the delay accounting patches (just like we did for the timespec_diff_ns change) Thanks, Shailabh >3. Do not multicast all replies, multicast only events generated due > to task exit. >4. The taskstats and taskstats_reply structures are now 64 bit aligned. >5. Family id is dynamically generated. > >Please let us know if we missed something out. > >Thanks, >Balbir > > >Signed-off-by: Shailabh Nagar >Signed-off-by: Balbir Singh > >--- > > include/linux/delayacct.h | 2 > include/linux/taskstats.h | 128 ++++++++++++++++++++++++ > include/net/genetlink.h | 20 +++ > init/Kconfig | 16 ++- > kernel/Makefile | 1 > kernel/delayacct.c | 56 ++++++++++ > kernel/taskstats.c | 244 ++++++++++++++++++++++++++++++++++++++++++++++ > 7 files changed, 464 insertions(+), 3 deletions(-) > > > ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642