From: Scott Bardone <sbardone@chelsio.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: maintainers@chelsio.com, jgarzik@pobox.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC: 2.6 patch] chelsio/espi.c:tricn_init(): remove dead code
Date: Thu, 09 Mar 2006 15:34:25 -0800 [thread overview]
Message-ID: <4410BB81.4050803@chelsio.com> (raw)
In-Reply-To: <20060309230653.GK21864@stusta.de>
This patch is correct, these two variables are unused in this driver. Thanks for
catching this!
Signed-off-by: Scott Bardone <sbardone@chelsio.com>
Adrian Bunk wrote:
> The Coverity checker spotted these two unused variables.
>
> Please check whether this patch is correct or whether they should be
> used.
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
> drivers/net/chelsio/espi.c | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
>
> --- linux-2.6.16-rc5-mm3-full/drivers/net/chelsio/espi.c.old 2006-03-09 23:19:54.000000000 +0100
> +++ linux-2.6.16-rc5-mm3-full/drivers/net/chelsio/espi.c 2006-03-09 23:20:35.000000000 +0100
> @@ -87,15 +87,9 @@
> static int tricn_init(adapter_t *adapter)
> {
> int i = 0;
> - int sme = 1;
> int stat = 0;
> int timeout = 0;
> int is_ready = 0;
> - int dynamic_deskew = 0;
> -
> - if (dynamic_deskew)
> - sme = 0;
> -
>
> /* 1 */
> timeout=1000;
> @@ -113,11 +107,9 @@
> }
>
> /* 2 */
> - if (sme) {
> - tricn_write(adapter, 0, 0, 0, TRICN_CNFG, 0x81);
> - tricn_write(adapter, 0, 1, 0, TRICN_CNFG, 0x81);
> - tricn_write(adapter, 0, 2, 0, TRICN_CNFG, 0x81);
> - }
> + tricn_write(adapter, 0, 0, 0, TRICN_CNFG, 0x81);
> + tricn_write(adapter, 0, 1, 0, TRICN_CNFG, 0x81);
> + tricn_write(adapter, 0, 2, 0, TRICN_CNFG, 0x81);
> for (i=1; i<= 8; i++) tricn_write(adapter, 0, 0, i, TRICN_CNFG, 0xf1);
> for (i=1; i<= 2; i++) tricn_write(adapter, 0, 1, i, TRICN_CNFG, 0xf1);
> for (i=1; i<= 3; i++) tricn_write(adapter, 0, 2, i, TRICN_CNFG, 0xe1);
>
prev parent reply other threads:[~2006-03-09 23:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-09 23:06 [RFC: 2.6 patch] chelsio/espi.c:tricn_init(): remove dead code Adrian Bunk
2006-03-09 23:34 ` Scott Bardone [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4410BB81.4050803@chelsio.com \
--to=sbardone@chelsio.com \
--cc=bunk@stusta.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maintainers@chelsio.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).