From: Patrick McHardy <kaber@trash.net>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: netdev@vger.kernel.org, hadi@cyberus.ca, lartc@mailman.ds9a.nl
Subject: Re: [PATCH] TC: bug fixes to the "sample" clause
Date: Mon, 13 Mar 2006 19:15:13 +0100 [thread overview]
Message-ID: <4415B6B1.8050402@trash.net> (raw)
In-Reply-To: <20060313100421.7df7f9ed@localhost.localdomain>
Stephen Hemminger wrote:
> The memset fix is in current CVS. I just wasn't going to take the
> patch that looked at utsname to decide what hash to use.
Yes, that sucks. We have another incompatibility, old iproute versions
(like the one shipped by Debian) show garbage statistics for HFSC. I
think it still works properly, but I wasn't able to track down the
cause. I have a feeling its somehow related to the gen_stats changes.
>>BTW, running valgrind on tc shows lots of uses of uninitialized values,
>>it seems like a good idea if someone would go over these and fix them
>>up.
>
>
> If we had a test script of commands (code coverage), that would help.
Getting good coverage looks like a lot of work, but I'll put it on
my TODO list for a boring day :)
next prev parent reply other threads:[~2006-03-13 18:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-10 2:33 [PATCH] TC: bug fixes to the "sample" clause Russell Stuart
[not found] ` <1142082696.5184.53.camel@jzny2>
2006-03-13 4:44 ` Russell Stuart
[not found] ` <1142269090.5242.29.camel@jzny2>
2006-03-13 17:55 ` Patrick McHardy
2006-03-13 18:04 ` Stephen Hemminger
2006-03-13 18:15 ` Patrick McHardy [this message]
2006-03-13 19:02 ` Patrick McHardy
2006-03-13 21:43 ` Russell Stuart
2006-03-13 21:50 ` Stephen Hemminger
2006-03-14 0:31 ` Russell Stuart
[not found] ` <1142303082.5219.16.camel@jzny2>
[not found] ` <1142306212.17608.178.camel@ras.pc.brisbane.lube>
[not found] ` <1142307572.5219.73.camel@jzny2>
[not found] ` <1142312708.17608.270.camel@ras.pc.brisbane.lube>
[not found] ` <1142436098.5346.3.camel@jzny2>
[not found] ` <1142470323.17608.341.camel@ras.pc.brisbane.lube>
[not found] ` <20060315165757.44bf1548@localhost.localdomain>
2006-03-16 1:43 ` Russell Stuart
[not found] ` <1142472481.5417.20.camel@jzny2>
[not found] ` <1142476647.17608.394.camel@ras.pc.brisbane.lube>
[not found] ` <1142478478.5417.46.camel@jzny2>
[not found] ` <1142488027.17608.485.camel@ras.pc.brisbane.lube>
[not found] ` <1142517116.5417.137.camel@jzny2>
2006-03-16 23:24 ` Russell Stuart
[not found] ` <1142606049.5322.89.camel@jzny2>
2006-03-18 5:10 ` Russell Stuart
2006-03-20 3:11 ` Russell Stuart
2006-03-14 2:29 ` Russell Stuart
[not found] ` <1142085718.5184.73.camel@jzny2>
[not found] ` <1142088594.4199.115.camel@ras.pc.stuart.local>
[not found] ` <1142092598.5184.93.camel@jzny2>
2006-03-14 2:45 ` Russell Stuart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4415B6B1.8050402@trash.net \
--to=kaber@trash.net \
--cc=hadi@cyberus.ca \
--cc=lartc@mailman.ds9a.nl \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).