From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95080C43381 for ; Mon, 25 Feb 2019 13:13:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 62F0821734 for ; Mon, 25 Feb 2019 13:13:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="cTI9IVpj"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="MorKTyrK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727121AbfBYNNf (ORCPT ); Mon, 25 Feb 2019 08:13:35 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:43196 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727120AbfBYNNf (ORCPT ); Mon, 25 Feb 2019 08:13:35 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 47FC260E59; Mon, 25 Feb 2019 13:13:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1551100414; bh=poxJ+n1Wwm8D7fH6A+QIDvcFNkloKUWGiC1ALKXYCZs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cTI9IVpjDLfFBoGrw87f8S3VegPhg2QPdeYBW3aNmzuttDD+I7zepfL/iBr8ViULp m7ykKZwwsP5Fkze2l40FW7hlhMd5Wh5CXA0c8Aykf7tWcSHxPVnHXf0Fc9eaRQ+vpn ReVGGeyvRmwT8qv57K344wvzXTkrg7oADdnCzdlY= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 9673360740; Mon, 25 Feb 2019 13:13:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1551100413; bh=poxJ+n1Wwm8D7fH6A+QIDvcFNkloKUWGiC1ALKXYCZs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MorKTyrK8Moi995nGUfi/UC29hrPmOeFJuS9jorwLs1oP3+q+4sDOhDIFjoGdtkLy /PQFCNEf8MjLUzREmRplYuKIMD7PLL/PR0PznO9Aa4dsqnY65EH1wybJnroiIdjAHY NTVVeObTWMGq4p36d522mYzA5xzVAMDgf+I8KSOU= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 25 Feb 2019 21:13:33 +0800 From: xiaofeis@codeaurora.org To: Andrew Lunn Cc: Vinod Koul , "David S. Miller" , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Vivien Didelot , Florian Fainelli , Niklas Cassel , netdev@vger.kernel.org Subject: Re: [PATCH] net: dsa: Inherit dev addr from master In-Reply-To: <20190222143003.GL5653@lunn.ch> References: <20190222125654.12478-1-vkoul@kernel.org> <20190222143003.GL5653@lunn.ch> Message-ID: <441ae81a814498876e4cfed6fd5b7bcb@codeaurora.org> X-Sender: xiaofeis@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2019-02-22 22:30, Andrew Lunn wrote: > On Fri, Feb 22, 2019 at 06:26:54PM +0530, Vinod Koul wrote: >> From: Xiaofei Shen >> >> When we create slave netdevice, the dev addr is inherited from master >> but the master dev addr maybe NULL at that time, so inherit it again >> while opening the slave. > > Hi Xiaofei, Vinod > > Inheriting it twice seems a bit clumsy. Can the first inherit be > removed? Can you change your MAC driver to set its MAC address in > probe? > > Andrew Hi Andrew Some mac driver set its MAC address in probe while some MAC driver do it in the open function in the kernel. This patch is checking whether the address is valid firstly, if it already inherits a valid mac address, it will not inherit again. I think we can remove the first inherit, but if keep it, we can see consistent address output by ifconfig -a before open master and slave interface. Xiaofeis