From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Boris B. Zhmurov" Subject: Re: [e1000 debug] KERNEL: assertion (!sk_forward_alloc) failed... Date: Thu, 30 Mar 2006 14:02:01 +0400 Message-ID: <442BAC99.2090404@kernelpanic.ru> References: <20060329.204409.109404254.davem@davemloft.net> <20060330095245.GA2385@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , jesse.brandeburg@intel.com, nipsy@bitgnome.net, jrlundgren@gmail.com, cat@zip.com.au, djani22@dynamicweb.hu, yoseph.basri@gmail.com, mykleb@no.ibm.com, olel@ans.pl, michal@feix.cz, chris@scorpion.nl, netdev@vger.kernel.org, jesse.brandeburg@gmail.com, E1000-devel@lists.sourceforge.net Return-path: To: Herbert Xu In-Reply-To: <20060330095245.GA2385@gondor.apana.org.au> Sender: e1000-devel-admin@lists.sourceforge.net Errors-To: e1000-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: List-Id: netdev.vger.kernel.org Hello, Herbert Xu. On 30.03.2006 13:52 you said the following: > On Wed, Mar 29, 2006 at 08:44:09PM -0800, David S. Miller wrote: > >>Herbert do you see any holes here? > > > Well I started from the beginning again, and found this. This may be > the smoking gun that we're after :) > > The xmit routine is lockless but checks last_tx_tso outside the locked > section. So if a TSO packet wins a race against a non-TSO packet with > last_tx_tso == 0 then we'll have memory corruption. > > Everyone, please try this patch and let us know whether the problem > goes away. > > Thanks, [zhmurov@builds linux-2.6.16]$ patch -p1 < ../../../SOURCES/linux-2.6.16-e1000-try-to-fix-assertion_sk_forward_alloc_failed_by_Herbert_Xu.patch patching file drivers/net/e1000/e1000_main.c Reversed (or previously applied) patch detected! Assume -R? [n] Herbert, is that patch already included in 2.6.16.1? -- Boris B. Zhmurov mailto: bb@kernelpanic.ru "wget http://kernelpanic.ru/bb_public_key.pgp -O - | gpg --import" ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642