From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Boris B. Zhmurov" Subject: Re: [e1000 debug] KERNEL: assertion (!sk_forward_alloc) failed... Date: Fri, 31 Mar 2006 16:07:03 +0400 Message-ID: <442D1B67.8000804@kernelpanic.ru> References: <442BAC99.2090404@kernelpanic.ru> <20060330101218.GA2905@gondor.apana.org.au> <442BDD25.1060000@kernelpanic.ru> <20060331.011245.26474207.davem@davemloft.net> <442D0186.8090705@kernelpanic.ru> <20060331103956.GA12181@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , jesse.brandeburg@intel.com, nipsy@bitgnome.net, jrlundgren@gmail.com, cat@zip.com.au, djani22@dynamicweb.hu, yoseph.basri@gmail.com, mykleb@no.ibm.com, olel@ans.pl, michal@feix.cz, chris@scorpion.nl, netdev@vger.kernel.org, jesse.brandeburg@gmail.com, E1000-devel@lists.sourceforge.net, Andi Kleen , Jeff Garzik Return-path: To: Herbert Xu In-Reply-To: <20060331103956.GA12181@gondor.apana.org.au> Sender: e1000-devel-admin@lists.sourceforge.net Errors-To: e1000-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: List-Id: netdev.vger.kernel.org Hello, Herbert Xu. On 31.03.2006 14:39 you said the following: > On Fri, Mar 31, 2006 at 02:16:38PM +0400, Boris B. Zhmurov wrote: > >>And xdelta tells, that e1000.ko was modified :) > > > Thanks for checking again. > > Anyway, it didn't take long to find another bug in the same area. > I'm afraid this driver does seem to be full of them :) > > It sets last_tx_tso in between computing the number of descriptors and > calling e1000_tx_map. This is bad because e1000_tx_map gets the wrong > value for last_tx_tso and therefore may corrupt memory for every TSO > packet when the ring is almost full. > > This bug exists on UP as well as SMP. > > Signed-off-by: Herbert Xu > > Please try this in conjunction with the previous patch. > > Cheers, David, Herbert - FYI. One of my colleague confirmed, that idea "bug reproducible only if there is more then one e1000 adapter onboard" is true. He has a 3 servers with double intel pro 1000 adapters, and that bug occurs. Also, he has 4 servers with double intel pro 1000 adapters onboard, but _only one_ of them is up. And there is no such messages in dmesg at all! Inetresting... -- Boris B. Zhmurov mailto: bb@kernelpanic.ru "wget http://kernelpanic.ru/bb_public_key.pgp -O - | gpg --import" ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642