From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Brandeburg Subject: Re: [TCP]: Fix truesize underflow Date: Wed, 19 Apr 2006 09:07:00 -0700 Message-ID: <44466024.9040800@intel.com> References: <20060418123204.GA3962@gondor.apana.org.au> <20060418.132256.110004342.davem@davemloft.net> <20060418232713.GA11938@gondor.apana.org.au> <4445D305.8080505@kernelpanic.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Herbert Xu , "David S. Miller" , kernel@linuxace.com, nipsy@bitgnome.net, jrlundgren@gmail.com, cat@zip.com.au, djani22@dynamicweb.hu, yoseph.basri@gmail.com, mykleb@no.ibm.com, olel@ans.pl, michal@feix.cz, chris@scorpion.nl, netdev@vger.kernel.org, jesse.brandeburg@gmail.com, ak@suse.de, jgarzik@pobox.com Return-path: Received: from fmr17.intel.com ([134.134.136.16]:65457 "EHLO orsfmr002.jf.intel.com") by vger.kernel.org with ESMTP id S1750892AbWDSQKo (ORCPT ); Wed, 19 Apr 2006 12:10:44 -0400 To: bb@kernelpanic.ru In-Reply-To: <4445D305.8080505@kernelpanic.ru> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Boris B. Zhmurov wrote: > Hello, Herbert Xu. > > On 19.04.2006 03:27 you said the following: > >> On Tue, Apr 18, 2006 at 01:22:56PM -0700, David S. Miller wrote: >> >>> I think it is deserving of some run time assertions, else these bugs >>> will elude us continually. Luckily there are only a few places that >>> would need the run time assertion checks on skb->truesize, and I'll >>> try to spend a few cycles on implementing this soon. >> >> >> Yes indeed. One place that comes to mind would be tcp_trim_head just >> before we munge truesize. >> >> Cheers, > > > I confirm, finally I don't see messages in dmesg about assertions. > Nice work :) > I can also confirm that both machines here had no problems after applying this patch. Good work!