From mboxrd@z Thu Jan 1 00:00:00 1970 From: Auke Kok Subject: Re: [PATCH 00/10] e1000: Driver fixes and update to 7.0.38-k2 Date: Sun, 23 Apr 2006 07:13:51 -0700 Message-ID: <444B8B9F.4050006@foo-projects.org> References: <443FF1A1.4000204@pobox.com> <20060422.225345.125621531.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: herbert@gondor.apana.org.au, jgarzik@pobox.com, auke-jan.h.kok@intel.com, netdev@vger.kernel.org, john.ronciak@intel.com, jesse.brandeburg@intel.com, Jeffrey.t.kirsher@intel.com, auke@foo-projects.org Return-path: Received: from mail5.sea5.speakeasy.net ([69.17.117.7]:35742 "EHLO mail5.sea5.speakeasy.net") by vger.kernel.org with ESMTP id S1750948AbWDWONy (ORCPT ); Sun, 23 Apr 2006 10:13:54 -0400 To: "David S. Miller" In-Reply-To: <20060422.225345.125621531.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org David S. Miller wrote: > From: Herbert Xu > Date: Sat, 22 Apr 2006 15:22:54 +1000 > >> Jeff Garzik wrote: >>>> 05/10: [PATCH] Update truesize with the length of the packet for >>>> packet split >>> These 10 patches look OK, but since the current kernel version is >>> 2.6.17-rc1, that means we are in "bug fix only" mode right now. >>> >>> Should I (a) apply these all to netdev2-.6.git#upstream, queueing them >>> for 2.6.18, or (b) let you split the submission into two parts, bug >>> fixes only and everything else? >> It turns out that the truesize patch is pretty important as otherwise >> most of TCP receive socket buffer accounting falls apart. So it should >> probably go into 2.6.17 and even 2.6.16-stable. > > I totally agree. > > Jeff please try to get at least this skb->truesize fix queued > to both -stable and current 2.6.x, it's really needed and > important for proper socket memory accounting on receive with > e1000. I agree, Jeff, please go ahead or let me know if you want me to submit this separately. Auke