From: Patrick McHardy <kaber@trash.net>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC] bridge: partial rtnetlink hooks
Date: Thu, 27 Apr 2006 10:24:18 +0200 [thread overview]
Message-ID: <44507FB2.5050002@trash.net> (raw)
In-Reply-To: <20060426104521.44682924@localhost.localdomain>
Stephen Hemminger wrote:
> This is the start of adding support for rtnetlink to the bridge code.
> So far it only supports accessing the list of links and notifying
> about link changes. It is just a prototype to get early feedback, don't
> use to build your own masterpiece yet.
>
> +static int br_dump_ifinfo(struct sk_buff *skb, struct netlink_callback *cb)
> +{
> + struct net_device *dev;
> + int idx = 0;
> + int err = 0;
> +
> + printk(KERN_DEBUG "bridge dump ifinfo\n");
> + for (dev = dev_base; dev; dev = dev->next) {
> + struct net_bridge_port *p = rcu_dereference(dev->br_port);
I think using rcu_dereference (especially without rcu_read_lock()) is
a bit misleading, the pointer is actually protected by the RTNL at
this point.
prev parent reply other threads:[~2006-04-27 8:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-26 17:45 [RFC] bridge: partial rtnetlink hooks Stephen Hemminger
2006-04-26 22:24 ` Francois Romieu
2006-04-26 22:43 ` David S. Miller
2006-04-27 8:24 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44507FB2.5050002@trash.net \
--to=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).