netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Just Marc <marc@corky.net>
To: netdev@vger.kernel.org
Subject: Disabling "TCP Treason uncloaked"
Date: Tue, 02 May 2006 17:19:29 +0100	[thread overview]
Message-ID: <44578691.4020402@corky.net> (raw)

Hi everyone,

Looking at mailing list archives there has been much talk of this print 
in the past, given the fact that this check/print is surrounded by an 
#ifdef TCP_DEBUG

#ifdef TCP_DEBUG
       if (net_ratelimit()) {
           struct inet_sock *inet = inet_sk(sk);
           printk(KERN_DEBUG "TCP: Treason uncloaked! Peer 
%u.%u.%u.%u:%u/%u shrinks window %u:%u. Repaired.\n",
                  NIPQUAD(inet->daddr), htons(inet->dport),
                  inet->num, tp->snd_una, tp->snd_nxt);
       }
#endif

I thought that maybe it's time to either set TCP_DEBUG to 0 or 
alternatively allow an admin to toggle the printing of this message 
off/on?  On a few busy web servers running usually latest versions of 
2.6 I have this message displaying hundreds (if not more) times a day, 
completely clogging the kernel log and making it harder to see if there 
are more interesting messages being printed.   TCP_DEBUG is being used 
in one more place that may also not require it anymore and or have it 
always enabled.

So, is it time to disable this print altogether? Is it time to allow an 
admin to toggle printing of this thing off?

Thanks for your time

             reply	other threads:[~2006-05-02 15:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-02 16:19 Just Marc [this message]
2006-05-02 16:02 ` Disabling "TCP Treason uncloaked" Andi Kleen
2006-05-03  4:44   ` Just Marc
2006-05-03  6:32   ` David S. Miller
2006-05-03  6:52     ` Andi Kleen
2006-05-03  8:06     ` Just Marc
2006-05-02 23:00 ` Herbert Xu
2006-05-03  4:10   ` Auke Kok
2006-05-03  4:46   ` Just Marc
2006-05-03  7:05     ` Herbert Xu
2006-05-03 11:47       ` Ingo Oeser
2006-05-03 12:21         ` Herbert Xu
2006-05-03 13:08         ` Just Marc
2006-05-03 12:11           ` Herbert Xu
2006-05-03 13:25             ` Just Marc
2006-05-03 12:49       ` Just Marc
2006-05-03 11:56         ` Herbert Xu
2006-05-03 12:15           ` Alexey Toptygin
2006-05-03 13:19             ` Herbert Xu
2006-05-03 13:11           ` Just Marc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44578691.4020402@corky.net \
    --to=marc@corky.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).